#3 use the PageDefinitions class to hold the parameters

1stthomas · Nov 5, 2021 · 2c20e33 · 2c20e33
1 parent 347221a
commit 2c20e33
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/controllers/single_page/dashboard/ht7/tools/settings.php b/controllers/single_page/dashboard/ht7/tools/settings.php
@@ -21,21 +21,19 @@ public function __construct(Page $c)
         $pkgFileConfig = $pkgH->getPackageFileConfig($this);
         $pkgHandle = $pkgH->getPackageHandle($this);
 
-        $this->definitions = new PageDefinitions(
-                [
-            'definitions' => ['forms.settings', $pkgFileConfig],
-            'elements' => [
-                'label' => ['tools/settings/label', $pkgHandle],
-                'setting' => ['tools/settings/attributes', $pkgHandle]
-            ],
-            'tabs' => ['ht7_tabs.settings', $pkgFileConfig],
-            'urls' => [
-                'form_abort' => $this->action(),
-                'form_save' => $this->action('save'),
-            ],
-            'values' => ['settings', $pkgFileConfig],
-                ],
-                PageDefinitionTypes::SIMPLE
+        $this->setDefinitions(new PageDefinitions([
+                    'definitions' => ['forms.settings', $pkgFileConfig],
+                    'elements' => [
+                        'label' => ['tools/settings/label', $pkgHandle],
+                        'setting' => ['tools/settings/attributes', $pkgHandle]
+                    ],
+                    'tabs' => ['ht7_tabs.settings', $pkgFileConfig],
+                    'urls' => [
+                        'form_abort' => $this->action(),
+                        'form_save' => $this->action('save'),
+                    ],
+                    'values' => ['settings', $pkgFileConfig],
+                        ], PageDefinitionTypes::SIMPLE)
         );
     }
 

diff --git a/src/Concrete/Ht7Tools/Controllers/AbstractHt7ToolsSettings.php b/src/Concrete/Ht7Tools/Controllers/AbstractHt7ToolsSettings.php
@@ -107,6 +107,11 @@ public function save()
         }
     }
 
+    public function setDefinitions(PageDefinitions $definitions)
+    {
+        $this->definitions = $definitions;
+    }
+
     public function view()
     {
         $this->requireAsset('javascript', 'ht7-widgets/concrete5');