[TASK] add error logging

1drop · Jan 21, 2019 · 8adffff · 8adffff
1 parent 7815cd6
commit 8adffff
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 1 deletion.
diff --git a/Classes/Exception.php b/Classes/Exception.php
@@ -17,6 +17,8 @@ class Exception extends FlowException
 {
     const NO_FOM_SELECTED_CODE = 1536740278;
     const NO_FOM_SELECTED_MESSAGE = 'No form selected';
+    const FORM_UNAVAILABLE_CODE = 1548082903;
+    const FORM_UNAVAILABLE_MESSAGE = 'Form unavailable';
 
     /**
      * @return Exception
@@ -25,4 +27,9 @@ public static function noFormSelected(): Exception
     {
         return new self(self::NO_FOM_SELECTED_MESSAGE, self::NO_FOM_SELECTED_CODE);
     }
+
+    public static function formUnavailable(): Exception
+    {
+        return new self(self::FORM_UNAVAILABLE_MESSAGE, self::FORM_UNAVAILABLE_CODE);
+    }
 }
diff --git a/Classes/FusionObjects/ExceptionHandler.php b/Classes/FusionObjects/ExceptionHandler.php
@@ -30,6 +30,7 @@ protected function handle($fusionPath, \Exception $exception, $referenceCode):st
         if (Exception::NO_FOM_SELECTED_CODE === $exception->getCode()) {
             return $this->runtime->render($fusionPath . '/noForm');
         }
+
         return (string)$exception;
     }
 }
diff --git a/Classes/FusionObjects/FormRuntimeFactory.php b/Classes/FusionObjects/FormRuntimeFactory.php
@@ -67,7 +67,7 @@ public function evaluate(): string
             $this->runtime
         );
         if (empty($formDefinition)) {
-            throw new Exception('Please select a form');
+            throw Exception::formUnavailable();
         }
 
         $request = $this->getRuntime()->getControllerContext()->getRequest();

diff --git a/Classes/Service/HubspotFormService.php b/Classes/Service/HubspotFormService.php
@@ -14,6 +14,7 @@
 
 use Neos\Cache\Frontend\VariableFrontend;
 use Neos\Flow\Annotations as Flow;
+use Psr\Log\LoggerInterface;
 use SevenShores\Hubspot\Exceptions\BadRequest;
 use SevenShores\Hubspot\Factory;
 use SevenShores\Hubspot\Resources\Forms;
@@ -44,6 +45,12 @@ class HubspotFormService
      */
     protected $settings = [];
 
+    /**
+     * @Flow\Inject
+     * @var \Neos\Flow\Log\SystemLoggerInterface
+     */
+    protected $systemLogger;
+
     /**
      * HubspotFormService constructor.
      */
@@ -124,9 +131,11 @@ public function getFormByIdentifier(string $formIdentifier = null): array
         try {
             $response = $this->forms->getById($formIdentifier);
         } catch (BadRequest $exception) {
+            $this->systemLogger->logException($exception);
             return [];
         }
         if (200 !== $response->getStatusCode()) {
+            $this->systemLogger->log('Hubspot API returned non 200 code', LOG_ERR, ['responseCode' => $response->getStatusCode()]);
             return [];
         }
 

diff --git a/Resources/Private/Fusion/Content/Form.fusion b/Resources/Private/Fusion/Content/Form.fusion
@@ -9,6 +9,15 @@ prototype(Onedrop.Form.Hubspot:FormRuntimeFactory) {
         content = 'Please select a hubspot form in the element inspector'
         @process.contentElementWrapping = Neos.Neos:ContentElementWrapping
     }
+
+    formUnavailable = Neos.Fusion:Tag {
+        tagName = 'div'
+        attributes {
+            class = 'onedrophubspot_noform'
+        }
+        content = 'The forms are temporarily not available'
+        @process.contentElementWrapping = Neos.Neos:ContentElementWrapping
+    }
 }
 
 prototype(Onedrop.Form.Hubspot:Content.Form) < prototype(Neos.Neos:ContentComponent) {