Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Enhancements]: Local Storage, Responsive CSS, and Response Regeneration #154

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

AdityaP700
Copy link
Contributor

@AdityaP700 AdityaP700 commented Oct 5, 2024

Overview:
This pull request refers to issue #146 which introduces several enhancements to the project, focusing on user experience and responsiveness.

Changes Made:

  1. Local Storage Implementation:
    • Added local storage functionality to save user inputs, improving data retention across sessions.
  2. Responsive Design Adjustments:
    • Updated CSS styles to enhance the responsiveness of the website, ensuring optimal viewing on various devices.
  3. Regenerative Response Button:
    • Implemented a new button that allows users to regenerate responses seamlessly, enhancing interaction with the application.
bandicam-2024-10-05-19-00-27-750_5SdOuUKG.mp4

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@AdityaP700 AdityaP700 changed the title Feat:Added Regenerate Button [UI Enhancements]: Local Storage, Responsive CSS, and Response Regeneration Oct 5, 2024
@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Oct 5, 2024

Concerned Project Admin @rawatji001 , please refer to my PR for issue #146 and if it's possible kindly merge this PR under any Level of GSSOC-extd and HackoctoberFest. Thanks in Anticipation.

Copy link
Owner

@1Shubham7 1Shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work @AdityaP700, these are really meaningful changes. There is one thing we need to reconsider, we would want a guy to only get one wife, if he regenerates , he should go back to the part where name is entered. what do you say : )

@1Shubham7
Copy link
Owner

your PR title, description everything is so well done, amazing brother, keep this up while contributing to larger projects too : )

@1Shubham7 1Shubham7 added gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended Level2 hacktoberfest hacktoberfest-accepted labels Oct 5, 2024
@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Oct 5, 2024

Hello @1Shubham7 ,thanks for your appreciation . Well i did had a thought of considering your point but since i was assigned to fix my issue so i simply made the changes accordingly . But since your suggestion seems legit ,i would surely update the codebase soon and raise the PR . Again Thanks for your kind Words :) ::Update : Had some issues persisting yet got clicked for review request ,will do the needful changes soon .

@AdityaP700 AdityaP700 requested a review from 1Shubham7 October 6, 2024 05:54
@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Oct 7, 2024

Hello @1Shubham7 ,Apologies for the delay. I was addressing a few other issues, but everything should be in order now. Please take a look at the latest changes when you have a chance. If you have any feedback, suggestions, or notice any issues, feel free to let me know. Looking forward for your input :)

bandicam.2024-10-08.02-12-41-621.mp4

Copy link
Owner

@1Shubham7 1Shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AdityaP700, you are a bit late, I merged someone's PR about response regeneration (we call it "Play again") . but this PR is really meaningful, I would request you to remove the response regeneration part from the PR and it is a good PR for local storage and CSS : )

@1Shubham7
Copy link
Owner

once you are done with changes, please change a video of how the website looks after that : )

@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Oct 8, 2024

Hello @1Shubham7 ,
I have made several CSS adjustments and functionality updates to address the issue of extra whitespace and overflow along the Y-axis when resizing the window.

  • Added margin: 0 and padding: 0 to html and body to eliminate extra whitespace and prevent overflow.
  • Removed negative margins in _.mainnav u_l li to ensure proper spacing and avoid layout issues.
  • Set the.superClass height to 100% for layout consistency and to avoid overflow.
  • Ensured the curve and other elements remain proportionate and responsive across different screen sizes.
  • Removed the "regenerate response" feature .
    Kindly look into my changes and i hope this time it works fine :) ,waiting for the input
bandicam-2024-10-08-14-28-25-722_jQ58eYzP.mp4

Copy link
Owner

@1Shubham7 1Shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't remove the playAgain button, make those changes : )

@@ -66,13 +103,6 @@ function ConfirmationCheckbox() {
setPerson(wives[randomNum]);
};

const playAgain = () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing the playAgain button? please don't remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apology for removing it ,will be adding it back with all functionality for sure

@AdityaP700 AdityaP700 requested a review from 1Shubham7 October 8, 2024 17:07
@AdityaP700
Copy link
Contributor Author

Hello @1Shubham7,Apologies for the delays and any confusion caused. As a beginner, this was one of my first issues, and I’ve learned a lot throughout the process—whether it’s using GitHub effectively, implementing React hooks, or performing responsive checks.
In the latest commit, I’ve re-added a Play Again button allowing users to restart the game. Additionally, I’ve fixed a minor bug in the My.css file, improving the overall styling .
https://github.com/user-attachments/assets/31122cdc-ef54-4ac5-90a0-d0735ec06318

I’ve made my latest commit, and I would appreciate it if you could kindly review it.

@1Shubham7
Copy link
Owner

Hello @1Shubham7,Apologies for the delays and any confusion caused. As a beginner, this was one of my first issues, and I’ve learned a lot throughout the process—whether it’s using GitHub effectively, implementing React hooks, or performing responsive checks. In the latest commit, I’ve re-added a Play Again button allowing users to restart the game. Additionally, I’ve fixed a minor bug in the My.css file, improving the overall styling . https://github.com/user-attachments/assets/31122cdc-ef54-4ac5-90a0-d0735ec06318

I’ve made my latest commit, and I would appreciate it if you could kindly review it.

You have done amazing work brother, keep it up! thanks a lot for your contribution : ) I think can be merged now : )

@1Shubham7 1Shubham7 merged commit bf29296 into 1Shubham7:main Oct 8, 2024
1 check passed
@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Oct 22, 2024

Hey there @1Shubham7 ,Well I have noticed that the PR which have been merged hasn't got updated in the leaderboard yet despite been for 2 weeks ,at first I thought due to some issues it wasn't updated so I kept waiting ,But still the issue has been there despite having the necessary Labels . Well I was suggested by the concerned admins to contact you regarding this so ,kindly look into this so as my PR can be reflected in the Leaderboard. Thanks in anticipation:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest hacktoberfest-accepted Level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants