Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added title and made it dynamic with input #132 #136

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jumankaushik
Copy link
Contributor

@jumankaushik jumankaushik commented Oct 2, 2024

Issue #132

  • Added the title on the Confirm.js page according to input value.

image

Result:

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

src/components/Confirm.js Outdated Show resolved Hide resolved
Copy link
Owner

@1Shubham7 1Shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the text color white or some other color, black isn't cool : )

@1Shubham7
Copy link
Owner

@jumankaushik always remember that one PR must only solve one issue, it is difficult to review a PR doing two things, please keep this PR about adding that text, edit the title and discription accordingly : )

@1Shubham7 1Shubham7 added gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended Level1 labels Oct 2, 2024
@jumankaushik
Copy link
Contributor Author

Okay

@jumankaushik
Copy link
Contributor Author

Done. Kindly check!

@jumankaushik jumankaushik changed the title Added title and made it dynamic with input and responsive #132 Added title and made it dynamic with input #132 Oct 2, 2024
@1Shubham7 1Shubham7 merged commit da02cd6 into 1Shubham7:main Oct 2, 2024
1 check passed
@1Shubham7
Copy link
Owner

Thanks for your contribution @jumankaushik

@jumankaushik
Copy link
Contributor Author

Hey @1Shubham7 , Please add the label of specifically gssoc-ext, hacktoberfest-accepted, hacktoberfest.. otherwise it will not be counted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest hacktoberfest-accepted Level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants