Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a title above the wife image #132

Closed
jumankaushik opened this issue Oct 1, 2024 · 7 comments
Closed

Add a title above the wife image #132

jumankaushik opened this issue Oct 1, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest hacktoberfest-accepted Level1

Comments

@jumankaushik
Copy link
Contributor

jumankaushik commented Oct 1, 2024

Add a title above the wife photo saying "XYZ, your future wife is" which will make it more dynamic and cool.
For eg., if my input is Raju, then it will say "Raju, your future wife is"

image

Kindly assign it under GSSOC and hacktoberfest. Thank you

@1Shubham7
Copy link
Owner

great, I think you should go ahead and implement the point 2 first and open another issue for point 1 : )

@jumankaushik
Copy link
Contributor Author

Okay on it. Kindly assign under GSSOC and hacktoberfest

@jumankaushik
Copy link
Contributor Author

Hey @1Shubham7 , it is done and I will send the PR in a while. Assign it under GSSOC-ext and hacktoberfest.

and @SaanyaGarg5 , this issue has already been assigned to me, so you can create your own issue or you can work on other issue which has not been assigned to anyone yet :)

@1Shubham7
Copy link
Owner

change the issue name and discription to be about about adding that title, you can add another PR for other stuff : )

@jumankaushik jumankaushik changed the title Return to play page when clicked and add a title Add a title above the wife image Oct 2, 2024
@jumankaushik
Copy link
Contributor Author

Done :)

1Shubham7 added a commit that referenced this issue Oct 2, 2024
Added title and made it dynamic with input #132
@jumankaushik
Copy link
Contributor Author

Hey @1Shubham7 , Please add the label of specifically gssoc-ext, hacktoberfest-accepted, hacktoberfest in the issue also.. otherwise it will not be counted :)

@1Shubham7 1Shubham7 added good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended Level1 hacktoberfest hacktoberfest-accepted labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest hacktoberfest-accepted Level1
Projects
None yet
Development

No branches or pull requests

3 participants
@jumankaushik @1Shubham7 and others