Nostradamus #142
Merged
Nostradamus #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redfast00
reviewed
Apr 20, 2024
| public class Nostradamus implements Positioner { | ||
| private static final Logger logger = Logger.getLogger(Nostradamus.class.getName()); | ||
| private final int INTERVAL_CALCULATE_MS = 500; // How often to handle new detections (in milliseconds) | ||
| private final int INTERVAL_FETCH_MS = 60000; // Interval between fetching baton switchovers (in milliseconds) |
There was a problem hiding this comment.
ik denk dat dit wel vaker mag gebeuren? of zorgt dat ergens voor problemen?
There was a problem hiding this comment.
Shorten the interval 27d1dc4
| private final int INTERVAL_FETCH_MS = 60000; // Interval between fetching baton switchovers (in milliseconds) | ||
| private final int INTERVAL_DETECTIONS_MS = 3000; // Amount of milliseconds to group detections by | ||
| private final int MAX_NO_DATA_MS = 30000; // Send a stationary position after receiving no station update for x amount of milliseconds | ||
| private final int AVERAGE_AMOUNT = 10; // Calculate the median running speed of the last x intervals |
There was a problem hiding this comment.
It's the only reference left to average. All the 10 other references say median so it's median but changed it anyway 877fe72
…y to fix simplePositioner cursedness with threading
NuttyShrimp
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New positioner (rebased on station-ws-conn)
Features:
Requires a restart:
Todo (at a later stage):