Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waas: use original intent to avoid data loss because of outdated struct #27

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

marino39
Copy link
Contributor

Since we will not be able to upgrade the authenticator freely we should pass on the original intents to any WaaS APIs.

Otherwise, if we have outdated e.g. IntentDataSendTransaction we may experience losing some data and not being able to verify signatures.

@marino39 marino39 requested a review from patrislav February 28, 2024 12:49
@marino39 marino39 merged commit 3c05bc4 into master Feb 28, 2024
2 checks passed
@marino39 marino39 deleted the waas-intent-data-loss-fix branch February 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants