Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest WebRPC #74

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Update to latest WebRPC #74

merged 4 commits into from
Nov 29, 2024

Conversation

klaidliadon
Copy link
Contributor

  • Updated to latest WebRPC
  • Updated to latest AuthControl
  • Updated the import script
  • Added a test case for IPV6

Copy link
Contributor

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please run ridlfmt on .ridl files.

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment.

@@ -1170,7 +1259,7 @@ const webrpcErrorByCode: { [code: number]: any } = {
[1005]: AbortedError,
[1006]: GeoblockedError,
[1007]: RateLimitedError,
[1100]: ProjectNotFoundError,
[1008]: ProjectNotFoundError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change this error code for any reason? If other projects rely on this value as of today, this may cause issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now defined in AuthControl now, since it's used also there, so I had to remove it here.

@klaidliadon klaidliadon merged commit f74bab2 into master Nov 29, 2024
1 check passed
@klaidliadon klaidliadon deleted the ipv6 branch November 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants