-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest WebRPC #74
Conversation
klaidliadon
commented
Nov 29, 2024
- Updated to latest WebRPC
- Updated to latest AuthControl
- Updated the import script
- Added a test case for IPV6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just please run ridlfmt on .ridl
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comment.
@@ -1170,7 +1259,7 @@ const webrpcErrorByCode: { [code: number]: any } = { | |||
[1005]: AbortedError, | |||
[1006]: GeoblockedError, | |||
[1007]: RateLimitedError, | |||
[1100]: ProjectNotFoundError, | |||
[1008]: ProjectNotFoundError, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we change this error code for any reason? If other projects rely on this value as of today, this may cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now defined in AuthControl now, since it's used also there, so I had to remove it here.