Wallet fee options #217
Merged
Wallet fee options #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamueleA
reviewed
Dec 17, 2024
There was a problem hiding this comment.
This is looking great!
Just two nitpicks:
- The "Refresh Balance" button should be removed IMO
We should take inspiration from https://sequence.app and streamline this. I think it's perfectly fine to just fetch the fee options and balances upon initially entering the view. If we want them to update in real time in case the user sends currency to his wallet we could have the data being fetched by a react-query hook with a 15-30 second staleTime for the cache.
- I'm noticing that the back button at the top is disabled in favor of the cancel button. I think we can go all the way and completely hide that back button since it serves no purpose.
corbanbrook
requested changes
Dec 17, 2024
|
@SamueleA I removed the refresh button + added react-query to fetch balances every 10 seconds, I wanted to keep the button opacity like this instead of removing, otherwise UI looks a bit jumpy :D @corbanbrook I added the image + border thingy latest Screen.Recording.2024-12-17.at.19.39.14.movalso updated https://kit-qa.pages.dev/ |
corbanbrook
approved these changes
Dec 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* WIP * Check for collection logo image * Make collection detail view image loader match container width * Disable back button in conformation screen * Add missing border radius for collection detail list item * Update fee option hook to allow last registered handler to be triggered * Show txn pending state in confirmation view * Fix zeroAddress and null case for native token fee option * Remove unnecessary id * Remove logs * Update transaction confirmation and fee option UIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.