Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch each secret only once, fix replacement of nested map values #13

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

VojtechVitek
Copy link
Contributor

@VojtechVitek VojtechVitek commented Oct 14, 2024

  • Fetch each secret only once, even if used multiple times
    • First object pass: Collect secret keys
    • Deduplicate secret keys & fetch secrets from provider
    • Second object pass: Replace secret values
  • Fixes replacement of the fields inside of map[string]Config values

@VojtechVitek VojtechVitek changed the title Fix replacement of nested map values Fetch each secret only once, fix replacement of nested map values Oct 14, 2024
@VojtechVitek VojtechVitek merged commit 2c0b19e into master Oct 14, 2024
1 check passed
@VojtechVitek VojtechVitek deleted the fix_map_struct_values branch October 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant