Tracking PR for v0.12.0 release #1585
Open
+3,603
−4,449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytes-next refactor: fix clippy warnings (`String::as_bytes`)
Memory handling of 2 reads at the same address in the same clock cycle
fix: fix typo in README
…state Refactor `Process` and `ProcessState`
Since the behavior if the key is already present is to replace the value with the new one there is no other error that can possibly arise in this method.
When merging forests, merge their advice maps and return error on key collision.
…t-add-advicemap Add `MastForest::advice_map` for the data required in the advice provider before execution
…ceProvider` trait
Also renames the variant to `FalconSigToStack`
…eToStack` In preparation for converting advice injectors to instructions. This parameter was never used, and is not crucial - the caller can always put the key on top of the stack before calling this injector.
…le, and rename AdviceInjector
…tors-emit Compiles advice injectors down to `Emit`
…t-advice-provider Refactor `Host` and `AdviceProvider`
It is redundant with `miden prove`, and runs code that is baked in to the CLI binary. This is not very useful to users, since they won't know the code that the example runs. It is better to just have people use `miden run` or `miden prove` on our example MASM programs.
The goal is to be able to reuse this file format for all targets (integration tests, benchmarks, and cli)
…cleanup Cleanup `program_execution` benchmark and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.