Minor MAST module cleanup #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
added
the
no changelog
plafer
approved these changes
Jul 22, 2024
| @@ -128,6 +126,8 @@ impl Deserializable for MastForest { | |||
| } | |||
|
|
|||
| for root in roots { | |||
| // make sure the root is valid in the context of the MAST forest | |||
| let root = MastNodeId::from_u32_safe(root, &mast_forest)?; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor cleanup of MAST-related modules in the
corecreate. The main changes are:MerkleTreeNodetrait as it doesn't seem like we use this abstraction anywhere.OpBatch-related code into a separate file.SerializableandDeserializableimplementations fromMastNodeIdand fixed a potential panic during deserialization ofMastForest.