Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MastForest serialization #1370

Merged
merged 130 commits into from
Jul 17, 2024
Merged

MastForest serialization #1370

merged 130 commits into from
Jul 17, 2024

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jun 27, 2024 •
edited
Loading

Builds on #1359

Implements serialization of MastForest, as described in 0xPolygonMiden/compiler#132 (and taking into account @bobbinth's comments).

Notably, MastNodeType has been implemented to fit into 8 bytes instead of the proposed 9.

plafer added 30 commits June 20, 2024 14:53
@plafer
Introduce ExternalNode
a94d52d
@plafer
Replace Assembler.node_id_by_digest map
f8ad339
@plafer
add TODOP
06f421b
@plafer
Add Host::get_mast_forest
bcf2a9b
@plafer
Move kernel and entrypoint out of MastForest
980713d
@plafer
Add Host::get_mast_forest
d2bbcd2
@plafer
Remove ProgramError
32e757e
@plafer
docs
f87217a
@plafer
cleanup Program constructors
71f35f1
@plafer
fix docs
a39f74f
@plafer
Make Program.kernel an Arc
f7e98af
@plafer
fix executable
b5538c5
@plafer
Merge remote-tracking branch 'origin/next' into plafer-object-store
2eab574
@plafer
invoke_mast_root: fix external node creation logic
188651b
@plafer
add failing test
b15263c
@plafer
don't make root in combine_mast_node_ids and compile_body
a94a095
@plafer
fix External docs
7af0bfa
@plafer
fmt
a6fcf47
@plafer
fix entrypoint doc
c66db6f
@plafer
Rename Program::new_with_kernel()
572fc7e
@plafer
Document MastForestStore and MemMastForestStore
08ce2c7
@plafer
fix syscall
50e01e9
@plafer
execute_* functions: use MastForest
071ab54
@plafer
Program: Remove Arc around kernel
49de40d
@plafer
remove Arc around MastForest in Program
c28c876
@plafer
Return error on malformed host
78b2b16
@plafer
Simplify DefaultHost
4883b44
@plafer
MastForest::add_node(): add docs
155a798
@plafer
fmt
bc6d13e
@plafer
add failing duplicate_procedure() test
be24320
@bobbinth bobbinth mentioned this pull request Jul 12, 2024
Closed
4 tasks
@plafer plafer mentioned this pull request Jul 12, 2024
Closed
@plafer plafer mentioned this pull request Jul 12, 2024
Closed
@plafer plafer requested a review from bobbinth July 12, 2024 14:53
@plafer
Copy link
Contributor Author

plafer commented Jul 12, 2024

Also added a few tests for MastNodeType serialization/deserialization.

bobbinth
bobbinth approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you! I left one non-blocking comment inline.

core/src/mast/serialization/info.rs Outdated Show resolved Hide resolved
@plafer plafer mentioned this pull request Jul 16, 2024
Merged
@plafer plafer mentioned this pull request Jul 17, 2024
Merged
bitwalker
bitwalker approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@plafer plafer merged commit b433b57 into next Jul 17, 2024
9 checks passed
@plafer plafer deleted the plafer-mast-forest-serialization branch July 17, 2024 14:30
@plafer plafer restored the plafer-mast-forest-serialization branch July 17, 2024 14:31
@plafer plafer deleted the plafer-mast-forest-serialization branch July 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@Fumuran Fumuran Fumuran left review comments

@bitwalker bitwalker bitwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plafer @bitwalker @Fumuran @bobbinth