Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement table-based MAST #1349

Merged
merged 109 commits into from
Jun 18, 2024
Merged

Implement table-based MAST #1349

merged 109 commits into from
Jun 18, 2024

Commits on Jun 5, 2024

  1. MastForest scaffolding

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    13fab50 View commit details
    Browse the repository at this point in the history

  2. implement CallNode and DynNode

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ede129f View commit details
    Browse the repository at this point in the history

  3. Implement BasicBlockNode processing

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2715666 View commit details
    Browse the repository at this point in the history

  4. implement External processing

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e36fb40 View commit details
    Browse the repository at this point in the history

  5. implement execute_mast

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    eee816b View commit details
    Browse the repository at this point in the history

  6. Add MastForest::add_node()

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fd77cf7 View commit details
    Browse the repository at this point in the history

  7. BasicBlockNode constructors

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e93889f View commit details
    Browse the repository at this point in the history

  8. JoinNode constructor

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    408f082 View commit details
    Browse the repository at this point in the history

  9. SplitNode constructor

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    464773a View commit details
    Browse the repository at this point in the history

  10. LoopNode constructor

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7276593 View commit details
    Browse the repository at this point in the history

  11. CallNode constructors

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6f607ae View commit details
    Browse the repository at this point in the history

  12. dyn and external constructors

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7fd1755 View commit details
    Browse the repository at this point in the history

  13. Remove comment

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fde1c72 View commit details
    Browse the repository at this point in the history

  14. SpanBuilder methods

    @plafer
    plafer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f9a1d0d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. MastNodeId: make u32

    @plafer
    plafer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ae2bd01 View commit details
    Browse the repository at this point in the history

  2. fmt

    @plafer
    plafer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2678a5a View commit details
    Browse the repository at this point in the history

  3. implement Index for MastForex, and mark inline(always)

    @plafer
    plafer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    979e6a3 View commit details
    Browse the repository at this point in the history

  4. Assembler: switch to use MastForest

    @plafer
    plafer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    805be4a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Assembler::assemble_test()

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d5db165 View commit details
    Browse the repository at this point in the history

  2. Add Display to MastForest

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    34fc0bb View commit details
    Browse the repository at this point in the history

  3. introduce MastNodePrettyPrint

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b408505 View commit details
    Browse the repository at this point in the history

  4. Introduce MastNodeDisplay

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    273bf76 View commit details
    Browse the repository at this point in the history

  5. fix nested_blocks test

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2babfde View commit details
    Browse the repository at this point in the history

  6. BasicBlockNode: fix pretty print

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    67106f3 View commit details
    Browse the repository at this point in the history

  7. revert basic_block change for now

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d99a915 View commit details
    Browse the repository at this point in the history

  8. fix procedure invocation

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    407f8ac View commit details
    Browse the repository at this point in the history

  9. Make MastForest::get_node_id() faillible, and use indexing everywhere

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d93c304 View commit details
    Browse the repository at this point in the history

  10. comment

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    93c11df View commit details
    Browse the repository at this point in the history

  11. Rename ExternalNode -> ProxyNode

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7411985 View commit details
    Browse the repository at this point in the history

  12. update hash_memoization_control_blocks

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d91bff1 View commit details
    Browse the repository at this point in the history

  13. update hash_memoization_control_blocks

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e7c06a3 View commit details
    Browse the repository at this point in the history

  14. update build_bar_hash()

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    17a2b6f View commit details
    Browse the repository at this point in the history

  15. update decoder tests

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ac3691f View commit details
    Browse the repository at this point in the history

  16. update processor tests

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    548009c View commit details
    Browse the repository at this point in the history

  17. Merge branch 'next' into plafer-table-based-mast

    @plafer
    plafer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3738d17 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. processor tests

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cae7bfe View commit details
    Browse the repository at this point in the history

  2. Remove CodeBlock and everything related

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    93f79da View commit details
    Browse the repository at this point in the history

  3. Move OpBatch

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    424f029 View commit details
    Browse the repository at this point in the history

  4. move tests

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d79adf1 View commit details
    Browse the repository at this point in the history

  5. Move Kernel

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    710a142 View commit details
    Browse the repository at this point in the history

  6. Move ProgramInfo

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    26566bb View commit details
    Browse the repository at this point in the history

  7. rename ensure_node()

    @plafer
    plafer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7c26f85 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Remove combine_basic_blocks()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    76f63dc View commit details
    Browse the repository at this point in the history

  2. inline procedures on exec

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    64a6b29 View commit details
    Browse the repository at this point in the history

  3. fix nested_blocks()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bce68f8 View commit details
    Browse the repository at this point in the history

  4. Remove Proxy node

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    63ac435 View commit details
    Browse the repository at this point in the history

  5. Add comment in invoke_mast_root() about our assumptions

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e9d2c92 View commit details
    Browse the repository at this point in the history

  6. move MastNode in submodule

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    354bbd3 View commit details
    Browse the repository at this point in the history

  7. rename execute_mast_node() and friends

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4f21406 View commit details
    Browse the repository at this point in the history

  8. Introduce Program

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3dc679a View commit details
    Browse the repository at this point in the history

  9. use Program everywhere

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9a1146c View commit details
    Browse the repository at this point in the history

  10. fix nested_control_blocks() test

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8556210 View commit details
    Browse the repository at this point in the history

  11. TestContext: use assemble_test()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7de110d View commit details
    Browse the repository at this point in the history

  12. program_with_nested_procedures fix

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9bef046 View commit details
    Browse the repository at this point in the history

  13. fix program_with_one_procedure()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b83bce5 View commit details
    Browse the repository at this point in the history

  14. remove ignored test program_with_empty_procedure

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    57e1341 View commit details
    Browse the repository at this point in the history

  15. fix program_with_one_import_and_hex_call

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bc93877 View commit details
    Browse the repository at this point in the history

  16. ignore phantom mast call

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    494f4ec View commit details
    Browse the repository at this point in the history

  17. fix comment_in_nested_control_blocks

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d616a81 View commit details
    Browse the repository at this point in the history

  18. fix test module_alias()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    73c162f View commit details
    Browse the repository at this point in the history

  19. fix program_with_proc_locals()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    22bcac7 View commit details
    Browse the repository at this point in the history

  20. fix program_with_reexported_proc_in_another/same_library

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    df8709b View commit details
    Browse the repository at this point in the history

  21. Remove procedure_cache() test capability from Assembler

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8546c21 View commit details
    Browse the repository at this point in the history

  22. Remove Assembler::assemble_test()

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f9c1d6e View commit details
    Browse the repository at this point in the history

  23. assemble_with_options_in_context needs to consume self

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8039cfb View commit details
    Browse the repository at this point in the history

  24. address TODOs

    @plafer
    plafer committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c8baccc View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. SplitNode: move to_pretty_print() impl

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7441749 View commit details
    Browse the repository at this point in the history

  2. Add DynNode digest test

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2773f37 View commit details
    Browse the repository at this point in the history

  3. verifier: export ProgramInfo and Kernel

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e50b961 View commit details
    Browse the repository at this point in the history

  4. execute: instrument("execute_program")

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    42b4b2a View commit details
    Browse the repository at this point in the history

  5. execute_mast_node: use get_node_id() in case of errors

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    aae29eb View commit details
    Browse the repository at this point in the history

  6. execute_call_node: use get_node_by_id()

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c98029e View commit details
    Browse the repository at this point in the history

  7. miden lib: restore all exports

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6dd2f0c View commit details
    Browse the repository at this point in the history

  8. fix miden crate

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8e01659 View commit details
    Browse the repository at this point in the history

  9. make batch_ops private

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4cdcffc View commit details
    Browse the repository at this point in the history

  10. basic_block_node: fix docstring indentation

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fb151de View commit details
    Browse the repository at this point in the history

  11. fix mast module path

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e0d5cdf View commit details
    Browse the repository at this point in the history

  12. fix Assembler::assemble_module()

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2b0a44c View commit details
    Browse the repository at this point in the history

  13. move set_kernel call

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fdad706 View commit details
    Browse the repository at this point in the history

  14. pretty print basic_block instead of span

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9adc496 View commit details
    Browse the repository at this point in the history

  15. cleanup MastNode.to_pretty_print

    @plafer
    plafer committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6960a56 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. fix doc tests

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d70308b View commit details
    Browse the repository at this point in the history

  2. clippy

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4c2af01 View commit details
    Browse the repository at this point in the history

  3. Update core/src/mast/mod.rs 

    Co-authored-by: Paul Schoenfelder <[email protected]>
    @plafer @bitwalker
    plafer and bitwalker authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ca59eb9 View commit details
    Browse the repository at this point in the history

  4. Update core/src/mast/mod.rs 

    Co-authored-by: Paul Schoenfelder <[email protected]>
    @plafer @bitwalker
    plafer and bitwalker authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1f6a13e View commit details
    Browse the repository at this point in the history

  5. Use as operator for usize <-> u32

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a31ecd4 View commit details
    Browse the repository at this point in the history

  6. inline(always) on index()

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4306ce2 View commit details
    Browse the repository at this point in the history

  7. use Option.get()

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6a06f32 View commit details
    Browse the repository at this point in the history

  8. remove unused file

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2ef3a98 View commit details
    Browse the repository at this point in the history

  9. Use binary_search instead of linear search

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ba75261 View commit details
    Browse the repository at this point in the history

  10. fix cli_run

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ab78daf View commit details
    Browse the repository at this point in the history

  11. fix asmop_repeat_test

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5b90c5b View commit details
    Browse the repository at this point in the history

  12. docstring

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2fde2ba View commit details
    Browse the repository at this point in the history

  13. fix test_falcon512_probabilistic_product_failure

    @plafer
    plafer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ceca4f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. introduce Assembler::assemble_program()

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    d3ff423 View commit details
    Browse the repository at this point in the history

  2. Rename error variant to MastNodeNotFoundInForest

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    60428d4 View commit details
    Browse the repository at this point in the history

  3. test_utils: compile() returns Program

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    5b70d83 View commit details
    Browse the repository at this point in the history

  4. fix generate_blake3_program()

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    bc8719d View commit details
    Browse the repository at this point in the history

  5. Use program.get_node_by_id() in the decoder

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    a062ba9 View commit details
    Browse the repository at this point in the history

  6. wrap at 100 and fix comment

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    fad9712 View commit details
    Browse the repository at this point in the history

  7. rename Procedure::code() to body_node terminology

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    c34a532 View commit details
    Browse the repository at this point in the history

  8. update changelog

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    4207e87 View commit details
    Browse the repository at this point in the history

  9. clippy

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    453f60f View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Remove disabled serialization tests

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7ac1212 View commit details
    Browse the repository at this point in the history

  2. Use try_into() for usize -> u32 conversion

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c310a6f View commit details
    Browse the repository at this point in the history

  3. Remove miette dependency from core

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d5c14c6 View commit details
    Browse the repository at this point in the history

  4. fix README

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    67343d1 View commit details
    Browse the repository at this point in the history

  5. Remove Program type annotation

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0d0e3e6 View commit details
    Browse the repository at this point in the history

  6. clippy

    @plafer
    plafer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    39411a2 View commit details
    Browse the repository at this point in the history