Implement internal BLAKE3 hashing example #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Dec 12, 2023
bobbinth
approved these changes
Dec 13, 2023
miden/Cargo.toml
Outdated
| clap = { version = "4.4", features = ["derive"], optional = true } | ||
| env_logger = { version = "0.10", default-features = false, optional = true } | ||
| hex = { version = "0.4", optional = true } | ||
| log = { version = "0.4", default-features = false, optional = true } | ||
| vm-core = { package = "miden-core", path = "../core", version = "0.8", default-features = false } |
There was a problem hiding this comment.
nit: could we put this into alphabetical order?
miden/src/examples/mod.rs
Outdated
| @@ -50,11 +51,18 @@ pub struct ExampleOptions { | |||
| //#[clap(about = "available examples")] | |||
| pub enum ExampleType { | |||
| /// Compute a Fibonacci sequence of the specified length | |||
| Fib { | |||
| Fibonacci { | |||
There was a problem hiding this comment.
nit: I'd probably keep the old name (unless there is a good reason to change it?).
There was a problem hiding this comment.
I decided to change it because this name defines what name we will use in the CLI call. So instead of
miden example fib -n 1000
we could call
miden example fibonacci -n 1000
I thought that name fib could be unclear, but it is not a big deal — I can change it back to the old name.
There was a problem hiding this comment.
I think fib is fine as it is easier to type :)
Fumuran
force-pushed
the
andrew-blake3-internal-example
branch
from
1f092c4 to
7be367d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new internal example: sequential calculation of 1-to-1 BLAKE3 hash.
As well as the fibonacci example it could be used with
examplesubcommand: