Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support libraries in Miden REPL #1162

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Nov 28, 2023

This PR makes it possible to specify libraries to be used in the REPL programs. It also introduces the !use command for Miden REPL. This command could be used with or without parameter.

  • If !use command is used without parameters, it prints all modules available for import to the program.
  • If !use command is used with parameter, it imports the provided module to the program.

@Fumuran Fumuran requested a review from bobbinth November 28, 2023 14:50
@Fumuran Fumuran linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline. Once these are addressed, we can merge.

@@ -18,6 +18,7 @@
- Introduced the `Event` decorator and an associated `on_event` handler on the `Host` trait (#1119).
- Updated Winterfell dependency to v0.7 (#1121).
- Added methods `StackOutputs::get_stack_item()` and `StackOutputs::get_stack_word()` (#1155).
- Introduced the `!use` command for the Miden REPL (#1162).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd create a new section for this - something like "CLI".

docs/src/tools/repl.md Outdated Show resolved Hide resolved
miden/src/cli/mod.rs Outdated Show resolved Hide resolved
miden/src/repl/mod.rs Outdated Show resolved Hide resolved
@Fumuran Fumuran force-pushed the andrew-support-stdlib-in-repl branch from 217ead7 to b3e4e1d Compare November 28, 2023 23:26
@Fumuran Fumuran force-pushed the andrew-support-stdlib-in-repl branch from b3e4e1d to ecb1699 Compare November 29, 2023 00:09
@Fumuran Fumuran merged commit f6bc75f into next Nov 29, 2023
15 checks passed
@Fumuran Fumuran deleted the andrew-support-stdlib-in-repl branch November 29, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stdlib (use.std::math::u64 etc) in miden repl
2 participants