-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the chiplet virtual table build #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
The src/chiplets/aux_trace/mod.rs
file is becoming quite big. I'm wondering if we should split it up into multiple files - but don't have specific suggestions on how to do it yet.
I think once we remove the code that will become redundant as a result of this PR, it will become easier to refactor the structure of this file and the ones related to it afterwords. |
c47b67b
to
7177585
Compare
7ca5384
to
7aabb8f
Compare
7177585
to
8e9fa01
Compare
…erflow Simplify stack overflow auxiliary column build
Simplify building the decoder auxiliary columns
Describe your changes
This PR proposes a simplification to the building process of the auxiliary column representing the chiplet virtual table. It builds on #1140 .
Checklist before requesting a review
next
according to naming convention.