Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the chiplet virtual table build #1161

Merged
merged 17 commits into from
Dec 13, 2023

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

This PR proposes a simplification to the building process of the auxiliary column representing the chiplet virtual table. It builds on #1140 .

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth November 27, 2023 15:14
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

The src/chiplets/aux_trace/mod.rs file is becoming quite big. I'm wondering if we should split it up into multiple files - but don't have specific suggestions on how to do it yet.

@Al-Kindi-0
Copy link
Collaborator Author

I think once we remove the code that will become redundant as a result of this PR, it will become easier to refactor the structure of this file and the ones related to it afterwords.

@bobbinth bobbinth force-pushed the al-simplify-aux-vtable branch from 7177585 to 8e9fa01 Compare December 5, 2023 09:01
@bobbinth bobbinth merged commit 5de10a6 into al-simplify-aux Dec 13, 2023
15 checks passed
@bobbinth bobbinth deleted the al-simplify-aux-vtable branch December 13, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants