-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cycles output in analyze
tool
#1099
Conversation
72a0a00
to
4afbbe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a couple of minor comments inline. After these are addressed, we can merge.
Also, could you paste a screenshot of how the output for this looks like?
4e953d3
to
c6d314c
Compare
c6d314c
to
26eed21
Compare
Looks great! A couple of minor comments on the output formatting:
Basically, the output could look like:
|
Looks good! Thank you! One last thing: could we add:
Before the |
81667b4
to
bf4dbdf
Compare
All looks good! Thank you! |
This PR adds extended information about traces lengths of VM components to the
analyze
tool output.