refactor: inline AdviceProvider provided methods

CHANGELOG.md

@@ -3,6 +3,7 @@
 #### Changes
 - [BREAKING] `Process` no longer takes ownership of the `Host` (#1571)
 - [BREAKING] `ProcessState` was converted from a trait to a struct (#1571)
+- [BREAKING] `Host` and `AdviceProvider` traits simplified (#1572)
 
 ## 0.11.0 (2024-11-04)
 

assembly/src/ast/tests.rs

@@ -470,10 +470,7 @@ fn test_ast_parsing_adv_injection() -> Result<(), Report> {
     use super::AdviceInjectorNode::*;
 
     let context = TestContext::new();
-    let source = source_file!(
-        &context,
-        "begin adv.push_u64div adv.push_mapval adv.insert_mem end"
-    );
+    let source = source_file!(&context, "begin adv.push_u64div adv.push_mapval adv.insert_mem end");
     let forms = module!(begin!(
         inst!(AdvInject(PushU64Div)),
         inst!(AdvInject(PushMapVal)),

miden/tests/integration/operations/decorators/mod.rs

@@ -1,7 +1,7 @@
 use std::sync::Arc;
 
 use processor::{
-    AdviceProvider, ExecutionError, Host, HostResponse, MastForest, MemAdviceProvider, ProcessState,
+    AdviceProvider, ExecutionError, Host, MastForest, MemAdviceProvider, ProcessState,
 };
 use vm_core::DebugOptions;
 
@@ -40,31 +40,23 @@ impl<A: AdviceProvider> Host for TestHost<A> {
         &mut self.adv_provider
     }
 
-    fn on_event(
-        &mut self,
-        _process: ProcessState,
-        event_id: u32,
-    ) -> Result<HostResponse, ExecutionError> {
+    fn on_event(&mut self, _process: ProcessState, event_id: u32) -> Result<(), ExecutionError> {
         self.event_handler.push(event_id);
-        Ok(HostResponse::None)
+        Ok(())
     }
 
-    fn on_trace(
-        &mut self,
-        _process: ProcessState,
-        trace_id: u32,
-    ) -> Result<HostResponse, ExecutionError> {
+    fn on_trace(&mut self, _process: ProcessState, trace_id: u32) -> Result<(), ExecutionError> {
         self.trace_handler.push(trace_id);
-        Ok(HostResponse::None)
+        Ok(())
     }
 
     fn on_debug(
         &mut self,
         _process: ProcessState,
         _options: &DebugOptions,
-    ) -> Result<HostResponse, ExecutionError> {
+    ) -> Result<(), ExecutionError> {
         self.debug_handler.push(_options.to_string());
-        Ok(HostResponse::None)
+        Ok(())
     }
 
     fn get_mast_forest(&self, _node_digest: &prover::Digest) -> Option<Arc<MastForest>> {

processor/src/host/advice/injectors/dsa.rs → processor/src/host/advice/dsa.rs

@@ -1,6 +1,6 @@
 use alloc::vec::Vec;
 
-use super::super::{ExecutionError, Felt, Word};
+use super::{ExecutionError, Felt, Word};
 
 /// Gets as input a vector containing a secret key, and a word representing a message and outputs a
 /// vector of values to be pushed onto the advice stack.