feat: remove local db from aggsender
#197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
changed the title
db from aggsender
goran-ethernal
changed the base branch from
main
to
feature/aggsender_recovery
goran-ethernal
force-pushed
the
CDK-594-aggsender-remove-db-use-memory
branch
from
c9a4f13
to
512bfa1
Compare
goran-ethernal
requested review from
joanestebanr,
Stefan-Ethernal and
arnaubennassar
vcastellm
reviewed
Nov 25, 2024
agglayer/client.go
Outdated
| @@ -158,3 +159,24 @@ func (c *AggLayerClient) GetEpochConfiguration() (*ClockConfiguration, error) { | |||
|
|
|||
| return result, nil | |||
| } | |||
|
|
|||
| // GetLatestKnownCertificateHeader returns the last certificate header submitted by networkID | |||
| func (c *AggLayerClient) GetLatestKnownCertificateHeader(networkID uint32) (*CertificateHeader, error) { | |||
There was a problem hiding this comment.
Stefan-Ethernal
force-pushed
the
CDK-594-aggsender-remove-db-use-memory
branch
from
512bfa1
to
dd6efaf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the local
aggsenderdb, and uses in memory saving of the last sent certificate.On startup, the
aggsenderwill get the last sent certificate for its network by using theinterop_getLatestKnownCertificateHeaderrpc endpoint onagglayer. If it isnil, it means thatagglayerdoesn't have any certificates from our network. If it has, we will save it in memory as the last sent certificate.Then, the flow is as it was:
agglayerhas no certificates from our network), or if it's status isSettledorInError,aggsenderwill proceed to build a new certificate.SettledorInErrorit means we can not build a new certificate, so we wait for the next chance to build it.Pros of removing local
aggsenderdb:agglayeras a source of truth.aggsenderconfig is smaller.aggsenderis faster since it saves the last sent certificate in memory, and it doesn't need to querydb.Cons:
aggsenderssending certs with sameNetworkID, or someone was manually sending certificates to theagglayer.