docs: document the config file #194
Open
+1,412
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- crates/cdk/src/main.rs: Evaluated as low risk
Comments skipped due to low confidence (1)
config/default.go:3
- The comment contains spelling errors. 'This' should be 'These' and 'doesnt' should be 'doesn't'.
// This values doesnt have a default value because depend on the environment / deployment
|
vcastellm
changed the title
rachit77
reviewed
Nov 22, 2024
rachit77
reviewed
Nov 22, 2024
Stefan-Ethernal
approved these changes
Nov 22, 2024
config/default.go
Outdated
| URL = "{{L1URL}}" | ||
|
|
||
| # ---------------------------------------------------------------------------- | ||
| # allow that L1 gas price calculation use multiple sources |
There was a problem hiding this comment.
Suggested change
| # allow that L1 gas price calculation use multiple sources | |
| # MultiGasProvider allows that L1 gas price calculation use multiple sources |
config/default.go
Outdated
| NumRequests = 1000 | ||
| Interval = "1s" | ||
| # ------------------------------------------------------------------------------ | ||
| # GRPC server host |
There was a problem hiding this comment.
Suggested change
| # GRPC server host | |
| # Host denotes GRPC server IP address |
config/default.go
Outdated
| Host = "0.0.0.0" | ||
|
|
||
| # ------------------------------------------------------------------------------ | ||
| # GRPC server port |
There was a problem hiding this comment.
Suggested change
| # GRPC server port | |
| # Port denotes the GRPC server port |
Comment on lines
+458
to
+468
| # ------------------------------------------------------------------------------ | ||
| # TxProfitabilityCheckerType type for checking is it profitable for aggregator to validate batch | ||
| # possible values: base/acceptall | ||
| # ------------------------------------------------------------------------------ | ||
| TxProfitabilityCheckerType = "acceptall" | ||
|
|
||
| # ------------------------------------------------------------------------------ | ||
| # TxProfitabilityMinReward min reward for base tx profitability checker when aggregator will validate batch | ||
| # this parameter is used for the base tx profitability checker | ||
| # ------------------------------------------------------------------------------ | ||
| TxProfitabilityMinReward = "1.1" |
There was a problem hiding this comment.
Double check, but I believe this was removed through #189.
There was a problem hiding this comment.
Why this was removed @ToniRamirezM?
| AggLayerTxTimeout = "5m" | ||
|
|
||
| # ------------------------------------------------------------------------------ | ||
| # AggLayerURL url of the agglayer service |
There was a problem hiding this comment.
Suggested change
| # AggLayerURL url of the agglayer service | |
| # AggLayerURL is the url of the agglayer service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation to config file
config.gowhen existing