feat: unpack and log agglayer errors #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
feat/agglayer-error-handling
branch
3 times, most recently
from
a076f0d
to
4ef77b4
Compare
goran-ethernal
requested review from
arnaubennassar,
Stefan-Ethernal and
joanestebanr
arnaubennassar
approved these changes
Nov 6, 2024
joanestebanr
approved these changes
Nov 8, 2024
Stefan-Ethernal
approved these changes
Nov 8, 2024
goran-ethernal
force-pushed
the
feat/agglayer-error-handling
branch
2 times, most recently
from
7915df1
to
f3c8b33
Compare
goran-ethernal
force-pushed
the
feat/agglayer-error-handling
branch
from
f3c8b33
to
fa6966e
Compare
|
joanestebanr
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: unpack and log agglayer errors (#158) * feat: unpack and log agglayer errors * feat: agglayer error unpacking * fix: lint and UT * feat: epoch notifier (#144) - Send certificates after a percentage of epoch - Require epoch configuration to AggLayer - Change config of `aggsender` adding: `BlockFinality` and `EpochNotificationPercentage` * refact: GetSequence method (#169) * feat: remove sanity check (#178) (#179) --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Rachit Sonthalia <[email protected]> Co-authored-by: Toni Ramírez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces error unpacking when getting a certificate header using the
interop_getCertificateHeaderrpc endpoint onagglayer.When
agglayermarks a certificate asInErrorit also packs the error in the json format ofCertificateHeaderstatus field. These errors can be different, where each error has its own unique error code and structure.This PR handles unmarshaling of these different errors, so we can log them when we get the certificate header from
agglayer, which can be useful for debugging purposes, to know in a clear way what was the cause of error when settling a certificate.Types of errors from Agglayer
There are 3 main types of errors that the
agglayercan return:TypeConversionError- errors that can occur on failure on the pessimistic proof witness generation from theLocalNetworkStateDataand the provide Certificate. List ofTypeConversionErrorscan be found here: https://agglayer.github.io/agglayer/agglayer_types/enum.Error.htmlProofGenerationError- errors that can occur on failure on the pessimistic proof execution, either natively or in the prover. List ofProofGenerationErrorscan be found here: https://agglayer.github.io/agglayer/pessimistic_proof/enum.ProofError.html.ProofVerificationError- errors that can occur on failure on the proof verification. List ofProofVerificationErrorscan be found here: https://agglayer.github.io/agglayer/agglayer_types/enum.ProofVerificationError.htmlWhat to review
Only
.gofiles..jsonfiles are just test vectors for different errors.