Fred/cleanup

.github/workflows/main.yaml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.10", "3.11", "3.12"]
+        python-version: ["3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}

pylintrc

@@ -155,7 +155,6 @@ disable=raw-checker-failed,
         missing-function-docstring,
         missing-class-docstring,
         missing-module-docstring,
-        too-many-positional-arguments
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

requirements.txt

@@ -1,3 +1,6 @@
+flake8
+isort
+pre-commit
+pylint
 pyserial
 setuptools
-pre-commit

sa818.py

@@ -78,10 +78,7 @@ def __init__(self, port=None, baud=DEFAULT_BAUDRATE):
         # Send initialization command and check the reply
         self.send(self.INIT)
         reply = self.readline()
-        if reply == "+DMOCONNECT:0":
-          # if expected response, proceed
-          break
-        else:
+        if reply != "+DMOCONNECT:0":
           # if unexpected response, try another port
           logger.debug("Port %s not SA818: %s", _port, reply)
           self.serial.close()
@@ -133,6 +130,7 @@ def version(self):
     return version
 
   def set_radio(self, frequency, offset, bw, squelch, ctcss, dcs, tail):
+    # pylint: disable=too-many-locals,too-many-positional-arguments
     tone = ctcss if ctcss else dcs
     if tone:                # 0000 = No ctcss or dcs tone
       tx_tone, rx_tone = tone