-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video playback with subtitles via "Universal Media Player" Unity plugin (based on VLC media player) #126
Draft
drojf
wants to merge
19
commits into
07th-mod:mod
Choose a base branch
from
drojf:f-ump-video
base: mod
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clicking on screen doesn't quit video - exiting program doesn't work as video still playing
- Fix exiting while video playing freezing game - Fix clicking to skip video not working - Continue automatically once video finishes (previously required a click)
- -1 = Disabled - 0 = Default, as chosen by UMP/VLC - 1 = First track - 2 = Second track...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP placeholder in case we ever add this feature to the main mod
Portalboy in the discord wanted to add video playback with subtitles for their translation (?), so they made a prototype using "Universal Media Player" plugin v2.0.3(?) (which uses VLC media player libraries internally).
Notably this should be able to play more video formats (so we don't need to re-encode), although I haven't tested it on any of the original movie files from various sources.
They gave me this prototype, and long story short I integrated it into the mod.
However I've only tested it on Windows, not Mac or Linux...I don't actually know how it's supposed to work tbh.
But since I got it working on Windows I thought I should raise a PR here.
Of note:
UMPManualEng.pdf