transaction refactoring #234
Conversation
|
@rudyryk i would like to explain you i created a milestone which has a goal to have reliable connections management in peewee-async. I belive this pr is the last big architecture changes required for the milestone. It is a draft yet :) After this pr, will need to correct the work with pool #221 and make testing, a lot of testing, load testing, review the code, try it on production and we can release 0.11.0 And I would also like to know your plans for the project, do you want to be a constant reviewer, do you want me to request a review for you? |
I'd want to get it to mature / stable state. And I like the direction you're developing the project to. Not sure how often I could do reviews, I think one or two significant PRs a week might work for me. |
Ok i got you. Let's make your review optional. I will tag you in significant requests and will not wait for you to review to merge changes. It does not mean i will merge the PR the next second after the tag :) You will have time to comment the pr if you want. Anyway we can always discuss and fix something even if the pr is already merged. I think it is a good process flow at the moment :) |
#228