Issue65 #66
Open
Issue65 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pmdb application while sending the read request can not predict the actual size of the result. Added changes in pmdb_obj_get_internal() to allocate buffer as per the approximate size sent by the client. But if server returns larger data, raft_client_reply_try_complete() will reallocate the buffer to be able to accomodate whole result. The actual reply size should also be sent by to client application through pmdb_obj_stat_t.
- User can pass NULL pointer to ask pmdb library to allocate the buffer as per the reply result. - Or user can pass buffer and pass expand_reply_buff = true to allow pmdb library to reallocate bigger buffer if reply result size is larger than application buffer. - Or user can pass the buffer and if expand_reply_buff = false, that indicates user don't want to reallocate bigger buffer if result size is larger than expacted. This can be applicable if user is very sure abour result size and do not expact result to be larger than value_size passed.
Added corresponding changes at golang application to be able to send expand_reply_buff flag. If expand_reply_buff is true, pmdb library can allocate/reallocate buffer if user have not passed any buffer/passed smaller buffer.
Issue #65 appears to be a corner case where a leader of a recently initialized cluster advances its log index by writing its self-commit to idx == 0. However, before the cluster members receive this update, they elect a new leader. The original leader then asserts in raft_server_append_entry_log_prepare_and_check() because raft_server_append_entry_log_prune_if_needed() did not change the log header since the raerqm_prev_log_index was < 0. This patch handles the issue by calling raft_instance_initialize_newest_entry_hdr() in the raerqm_prev_log_index < 0 case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.