DB setup fix for new builds + build fix for ffmpeg >4.x #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding forcedLive in early migration functions was unneeded. Fixes migration issue without bumping version of already setup DBs.
shamipan
changed the title
|
Needed to get builds working on arch and any other distro not still on ffmpeg 4.x |
I'm not sure this f5a99ab correct after accepting last PR. Regarding thumbnailer we use debian in a container and we don't have this problem right now. I'm not sure if it won't break our running build and we have to change/fixing the container. |
|
I needed the thumbnailer fork to build on an arch vm. The DB edit wouldn't affect the live server, but the current setup isn't going to cause issues either unless you needed to setup a new DB. Closing for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding forcedLive to the early setup functions in migrations.go wasn't necessary. This shouldn't trigger any DB misbehavior, I've tested it on version103 (pre-PR7) to 105(post-PR7) upgrades and new DB creation. It won't trigger a version bump since no functions have been added/removed.