-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi qr code reader #376
base: master
Are you sure you want to change the base?
Conversation
odahcam
commented
Dec 4, 2020
- Added support for multiple QR code scanning from the same image.
- Added tests for the feature.
- Updated some classes this feature depends on.
- Updated Sharp.
…ng-js/library into feature/multi-qr-code-reader
Based on comments in the UPCEAN Pull-Request discussion this is where we land I think constructor(arg1: any);
constructor(arg1: any, arg2: any);
constructor(arg1: any, arg2: any, arg3: any);
constructor(arg1: any, arg2?: any, arg3?: any) {
if (arg2 == null) arg2 = {};
if (arg3 == null) arg3 = {};
return constructorImpl(arg1, arg2, arg3)
}
constructorImpl(arg1: any, arg2: any, arg3: any) {
/* Implementation code */
} and less preferred if more advanced logic needed constructor(arg1: any);
constructor(arg1: any, arg2: any);
constructor(arg1: any, arg2: any, arg3: any);
constructor(arg1: any, arg2?: any, arg3?: any) {
if (arg3 != null) return constructorImpl(arg1, arg2, arg3);
if (arg2 != null) return constructorOverload2(arg1, arg2);
return constructorOverload1(arg1)
}
private constructorOverload1(
arg1: any,
) {
return this.constructorOverload2(arg1, {});
}
private constructorOverload2(
arg1: any,
arg2: any,
) {
return this.constructorImpl(arg1, arg2, {});
}
private constructorImpl(
arg1: any,
arg2: any,
arg3: any,
) {
/* Implementation code */
} |
What massive error I did merging master onto this branch. |
Any updates in this PR? I'm trying to use this branch in my project and hope this branch will be merged into master. |
|
||
static processStructuredAppend( results: List<Result>): List<Result> { | ||
const newResults: List<Result> = []; | ||
const saResults: List<Result> = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create multiple saResults: List<Result>
that grouped by ResultMetadataType.STRUCTURED_APPEND_PARITY
to handle multi parity structured append qr codes in one document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip!! Can you help me with some examples or a PR?
i love this PR. |
Also bumping this PR. Let me know how I can help. |
I made some minor fixes and created PR #464 to merge into |
Fix for feature/multi qr code reader