Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

Commit

Permalink
guides: gives clear instructions for feedback, removes links to the n…
Browse files Browse the repository at this point in the history
…ow archived LH project
  • Loading branch information
fxn committed Nov 19, 2010
1 parent 6bd93f6 commit 902ae14
Show file tree
Hide file tree
Showing 30 changed files with 37 additions and 70 deletions.
2 changes: 1 addition & 1 deletion railties/guides/assets/stylesheets/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ h6 {
padding: 0.125em 0 0.25em 28px;*/
}

#mainCol dd.ticket, #subCol dd.ticket {
#mainCol dd.work-in-progress, #subCol dd.work-in-progress {
background: #fff9d8 url(../images/tab_yellow.gif) no-repeat left top;
border: none;
padding: 1.25em 1em 1.25em 48px;
Expand Down
9 changes: 2 additions & 7 deletions railties/guides/rails_guides/helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,14 @@ def guide(name, url, options = {}, &block)
link = content_tag(:a, :href => url) { name }
result = content_tag(:dt, link)

if ticket = options[:ticket]
result << content_tag(:dd, lh(ticket), :class => 'ticket')
if options[:work_in_progress]
result << content_tag(:dd, 'Work in progress', :class => 'work-in-progress')
end

result << content_tag(:dd, capture(&block))
result
end

def lh(id, label = "Lighthouse Ticket")
url = "http://rails.lighthouseapp.com/projects/16213/tickets/#{id}"
content_tag(:a, label, :href => url)
end

def author(name, nick, image = 'credits_pic_blank.gif', &block)
image = "images/#{image}"

Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/action_controller_overview.textile
Original file line number Diff line number Diff line change
Expand Up @@ -814,8 +814,6 @@ NOTE: Certain exceptions are only rescuable from the +ApplicationController+ cla

h3. Changelog

"Lighthouse Ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/17

* February 17, 2009: Yet another proofread by Xavier Noria.

* November 4, 2008: First release version by Tore Darell
2 changes: 0 additions & 2 deletions railties/guides/source/action_mailer_basics.textile
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,4 @@ In the test we send the email and store the returned object in the +email+ varia

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213/tickets/25

* September 30, 2010: Fixed typos and reformatted Action Mailer configuration table for better understanding. "Jaime Iniesta":http://jaimeiniesta.com
2 changes: 0 additions & 2 deletions railties/guides/source/action_view_overview.textile
Original file line number Diff line number Diff line change
Expand Up @@ -1472,7 +1472,5 @@ You can read more about the Rails Internationalization (I18n) API "here":i18n.ht

h3. Changelog

"Lighthouse Ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/71

* September 3, 2009: Continuing work by Trevor Turk, leveraging the "Action Pack docs":http://ap.rubyonrails.org/ and "What's new in Edge Rails":http://ryandaigle.com/articles/2007/8/3/what-s-new-in-edge-rails-partials-get-layouts
* April 5, 2009: Starting work by Trevor Turk, leveraging Mike Gunderloy's docs
2 changes: 0 additions & 2 deletions railties/guides/source/active_record_querying.textile
Original file line number Diff line number Diff line change
Expand Up @@ -928,8 +928,6 @@ For options, please see the parent section, "Calculations":#calculations.

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/16

* April 7, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* February 3, 2010: Update to Rails 3 by "James Miller":credits.html#bensie
* February 7, 2009: Second version by "Pratik":credits.html#lifo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1160,8 +1160,6 @@ config.active_record.observers = :mailer_observer

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213/tickets/26-active-record-validations-and-callbacks

* July 20, 2010: Fixed typos and rephrased some paragraphs for clarity. "Jaime Iniesta":http://jaimeiniesta.com
* May 24, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* May 15, 2010: Validation Errors section updated by "Emili Parreño":http://www.eparreno.com
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/active_support_core_extensions.textile
Original file line number Diff line number Diff line change
Expand Up @@ -3401,7 +3401,5 @@ NOTE: Defined in +active_support/core_ext/load_error.rb+.

h3. Changelog

"Lighthouse ticket":https://rails.lighthouseapp.com/projects/16213/tickets/67

* August 10, 2010: Starts to take shape, added to the index.
* April 18, 2009: Initial version by "Xavier Noria":credits.html#fxn
2 changes: 0 additions & 2 deletions railties/guides/source/association_basics.textile
Original file line number Diff line number Diff line change
Expand Up @@ -1876,8 +1876,6 @@ Extensions can refer to the internals of the association proxy using these three

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/11

* April 7, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* April 19, 2009: Added +:touch+ option to +belongs_to+ associations by "Mike Gunderloy":credits.html#mgunderloy
* February 1, 2009: Added +:autosave+ option "Mike Gunderloy":credits.html#mgunderloy
Expand Down
1 change: 0 additions & 1 deletion railties/guides/source/caching_with_rails.textile
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ h3. Further reading


h3. Changelog
"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/10-guide-to-caching

* May 02, 2009: Formatting cleanups
* April 26, 2009: Clean up typos in submitted patch
Expand Down
3 changes: 0 additions & 3 deletions railties/guides/source/command_line.textile
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,3 @@ h5. Miscellaneous Tasks

+rake routes+ will list all of your defined routes, which is useful for tracking down routing problems in your app, or giving you a good overview of the URLs in an app you're trying to get familiar with.

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213/tickets/29
2 changes: 0 additions & 2 deletions railties/guides/source/configuring.textile
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,6 @@ Some parts of Rails can also be configured externally by supplying environment v

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/28

* August 13, 2009: Updated with config syntax and added general configuration options by "John Pignata"
* January 3, 2009: First reasonably complete draft by "Mike Gunderloy":credits.html#mgunderloy
* November 5, 2008: Rough outline by "Mike Gunderloy":credits.html#mgunderloy
2 changes: 1 addition & 1 deletion railties/guides/source/contribute.textile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
h2. Contribute to the Rails Guides

Rails Guides aim to improve the Rails documentation and to make the barrier to entry as low as possible. A reasonably experienced developer should be able to use the Guides to come up to speed on Rails quickly. You can track the overall effort at the "Rails Guides Lighthouse":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets. Our sponsors have contributed prizes for those who write an entire guide, but there are many other ways to contribute.
Rails Guides aim to improve the Rails documentation and to make the barrier to entry as low as possible. A reasonably experienced developer should be able to use the guides to come up to speed on Rails quickly. Our sponsors have contributed prizes for those who write an entire guide, but there are many other ways to contribute.

endprologue.

Expand Down
4 changes: 1 addition & 3 deletions railties/guides/source/contributing_to_rails.textile
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ h3. Contributing to the Rails Documentation

Another area where you can help out if you're not yet ready to take the plunge to writing Rails core code is with Rails documentation. You can help with the Rails Guides or the Rails API documentation.

TIP: "docrails":http://github.com/lifo/docrails/tree/master is the documentation branch for Rails with an *open commit policy*. You can simply PM "lifo":http://github.com/lifo on Github and ask for the commit rights. Documentation changes made as part of the "docrails":http://github.com/lifo/docrails/tree/master project are merged back to the Rails master code from time to time. Check out the "original announcement":http://weblog.rubyonrails.org/2008/5/2/help-improve-rails-documentation-on-git-branch for more details.
TIP: "docrails":http://github.com/lifo/docrails/tree/master is the documentation branch for Rails with an *open commit policy*, it has public write access. Documentation changes made as part of the "docrails":http://github.com/lifo/docrails/tree/master project are merged back to the Rails master code from time to time. Check out the "original announcement":http://weblog.rubyonrails.org/2008/5/2/help-improve-rails-documentation-on-git-branch for more details.

h4. The Rails Guides

Expand Down Expand Up @@ -300,8 +300,6 @@ And then...think about your next contribution!

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/64

* April 6, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* August 1, 2009: Updates/amplifications by "Mike Gunderloy":credits.html#mgunderloy
* March 2, 2009: Initial draft by "Mike Gunderloy":credits.html#mgunderloy
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/debugging_rails_applications.textile
Original file line number Diff line number Diff line change
Expand Up @@ -704,8 +704,6 @@ h3. References

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/5

* April 4, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* November 3, 2008: Accepted for publication. Added RJS, memory leaks and plugins chapters by "Emilio Tagua":credits.html#miloops
* October 19, 2008: Copy editing pass by "Mike Gunderloy":credits.html#mgunderloy
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/form_helpers.textile
Original file line number Diff line number Diff line change
Expand Up @@ -776,8 +776,6 @@ Many apps grow beyond simple forms editing a single object. For example when cre

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/1

* April 6, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com

h3. Authors
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/generators.textile
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,6 @@ Fallbacks allow your generators to have a single responsibility, increasing code

h3. Changelog

"Lighthouse Ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/102

* August 23, 2010: Edit pass by "Xavier Noria":credits.html#fxn

* April 30, 2010: Reviewed by José Valim
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/getting_started.textile
Original file line number Diff line number Diff line change
Expand Up @@ -1469,8 +1469,6 @@ Two very common sources of data that are not UTF-8:

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/2

* August 30, 2010: Minor editing after Rails 3 release by "Joost Baaij":http://www.spacebabies.nl
* July 12, 2010: Fixes, editing and updating of code samples by "Jaime Iniesta":http://jaimeiniesta.com
* May 16, 2010: Added a section on configuration gotchas to address common encoding problems that people might have by "Yehuda Katz":http://www.yehudakatz.com
Expand Down
5 changes: 0 additions & 5 deletions railties/guides/source/i18n.textile
Original file line number Diff line number Diff line change
Expand Up @@ -889,8 +889,3 @@ fn1. Or, to quote "Wikipedia":http://en.wikipedia.org/wiki/Internationalization_
fn2. Other backends might allow or require to use other formats, e.g. a GetText backend might allow to read GetText files.

fn3. One of these reasons is that we don't want to imply any unnecessary load for applications that do not need any I18n capabilities, so we need to keep the I18n library as simple as possible for English. Another reason is that it is virtually impossible to implement a one-fits-all solution for all problems related to I18n for all existing languages. So a solution that allows us to exchange the entire implementation easily is appropriate anyway. This also makes it much easier to experiment with custom features and extensions.


h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213/tickets/23
14 changes: 7 additions & 7 deletions railties/guides/source/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Ruby on Rails Guides
<div id="subCol">
<dl>
<dd class="warning">Rails Guides are a result of the ongoing <a href="http://hackfest.rubyonrails.org">Guides hackfest</a>, and a work in progress.</dd>
<dd class="ticket">Guides marked with this icon are currently being worked on. While they might still be useful to you, they may contain incomplete information and even errors. You can help by reviewing them and posting your comments and corrections at the respective Lighthouse ticket.</dd>
<dd class="work-in-progress">Guides marked with this icon are currently being worked on. While they might still be useful to you, they may contain incomplete information and even errors. You can help by reviewing them and posting your comments and corrections to the author.</dd>
</dl>
</div>
<% end %>
Expand Down Expand Up @@ -71,7 +71,7 @@ Ruby on Rails Guides
<p>This guide covers the basic layout features of Action Controller and Action View, including rendering and redirecting, using content_for blocks, and working with partials.</p>
<% end %>

<%= guide("Action View Form Helpers", 'form_helpers.html', :ticket => 1) do %>
<%= guide("Action View Form Helpers", 'form_helpers.html', :work_in_progress => true) do %>
<p>Guide to using built-in Form helpers.</p>
<% end %>
</dl>
Expand Down Expand Up @@ -100,11 +100,11 @@ Ruby on Rails Guides
<p>This guide covers how to add internationalization to your applications. Your application will be able to translate content to different languages, change pluralization rules, use correct date formats for each country and so on.</p>
<% end %>

<%= guide("Action Mailer Basics", 'action_mailer_basics.html', :ticket => 25) do %>
<%= guide("Action Mailer Basics", 'action_mailer_basics.html', :work_in_progress => true) do %>
<p>This guide describes how to use Action Mailer to send and receive emails.</p>
<% end %>

<%= guide("Testing Rails Applications", 'testing.html', :ticket => 8) do %>
<%= guide("Testing Rails Applications", 'testing.html', :work_in_progress => true) do %>
<p>This is a rather comprehensive guide to doing both unit and functional tests in Rails. It covers everything from &quot;What is a test?&quot; to the testing APIs. Enjoy.</p>
<% end %>

Expand All @@ -124,19 +124,19 @@ Ruby on Rails Guides
<p>This guide covers the basic configuration settings for a Rails application.</p>
<% end %>

<%= guide("Rails Command Line Tools and Rake tasks", 'command_line.html', :ticket => 29) do %>
<%= guide("Rails Command Line Tools and Rake tasks", 'command_line.html', :work_in_progress => true) do %>
<p>This guide covers the command line tools and rake tasks provided by Rails.</p>
<% end %>

<%= guide("Caching with Rails", 'caching_with_rails.html', :ticket => 10) do %>
<%= guide("Caching with Rails", 'caching_with_rails.html', :work_in_progress => true) do %>
<p>Various caching techniques provided by Rails.</p>
<% end %>
</dl>

<h3>Extending Rails</h3>

<dl>
<%= guide("The Basics of Creating Rails Plugins", 'plugins.html', :ticket => 32) do %>
<%= guide("The Basics of Creating Rails Plugins", 'plugins.html', :work_in_progress => true) do %>
<p>This guide covers how to build a plugin to extend the functionality of Rails.</p>
<% end %>

Expand Down
25 changes: 25 additions & 0 deletions railties/guides/source/layout.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,31 @@
<div class="wrapper">
<div id="mainCol">
<%= yield.html_safe %>

<h3>Feedback</h3>
<p>
You're encouraged to help in keeping the quality of this guide.
</p>
<p>
If you see any typos or factual errors you are confident to
patch please clone <%= link_to 'docrails', 'https://github.com/lifo/docrails' %>
and push the change yourself. That branch of Rails has public write access.
Commits are still reviewed, but that happens after you've submitted your
contribution. <%= link_to 'docrails', 'https://github.com/lifo/docrails' %> is
cross-merged with master periodically.
</p>
<p>
You may also find incomplete content, or stuff that is not up to date.
Please do add any missing documentation for master. Check the
<%= link_to 'Ruby on Rails Guides Guidelines', 'ruby_on_rails_guides_guidelines.html' %>
guide for style and conventions.
</p>
<p>
Issues may also be reported <%= link_to 'in Github', 'https://github.com/lifo/docrails/issues' %>.
</p>
<p>And last but not least, any kind of discussion regarding Ruby on Rails
documentation is very welcome in the <%= link_to 'rubyonrails-docs mailing list', 'http://groups.google.com/group/rubyonrails-docs' %>.
</p>
</div>
</div>
</div>
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/layouts_and_rendering.textile
Original file line number Diff line number Diff line change
Expand Up @@ -1194,8 +1194,6 @@ There are several ways of getting similar results with different sub-templating

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/15

* April 4, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* January 25, 2010: Rails 3.0 Update by "Mikel Lindsaar":credits.html#raasdnil
* December 27, 2008: Merge patch from Rodrigo Rosenfeld Rosas covering subtemplates
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/migrations.textile
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,5 @@ Although Active Record does not provide any tools for working directly with such

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/6

* July 15, 2010: minor typos corrected by "Jaime Iniesta":http://jaimeiniesta.com
* September 14, 2008: initial version by "Frederick Cheung":credits.html#fcheung
2 changes: 0 additions & 2 deletions railties/guides/source/performance_testing.textile
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,5 @@ Rails has been lucky to have two startups dedicated to Rails specific performanc

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/4

* January 9, 2009: Complete rewrite by "Pratik":credits.html#lifo
* September 6, 2008: Initial version by Matthew Bergman
2 changes: 0 additions & 2 deletions railties/guides/source/plugins.textile
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,5 @@ The final plugin should have a directory structure that looks something like thi

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213/tickets/32-update-plugins-guide

* April 4, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* November 17, 2008: Major revision by Jeff Dean
2 changes: 0 additions & 2 deletions railties/guides/source/rails_application_templates.textile
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,4 @@ git :commit => "-a -m 'Initial commit'"

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/78

* April 29, 2009: Initial version by "Pratik":credits.html#lifo
2 changes: 0 additions & 2 deletions railties/guides/source/rails_on_rack.textile
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,5 @@ h4. Understanding Middlewares

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/58

* February 7, 2009: Second version by "Pratik":credits.html#lifo
* January 11, 2009: First version by "Pratik":credits.html#lifo
2 changes: 0 additions & 2 deletions railties/guides/source/routing.textile
Original file line number Diff line number Diff line change
Expand Up @@ -853,8 +853,6 @@ assert_routing({ :path => "photos", :method => :post }, { :controller => "photos

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/3

* April 10, 2010: Updated guide to remove outdated and superfluous information, and to provide information about new features, by "Yehuda Katz":http://www.yehudakatz.com
* April 2, 2010: Updated guide to match new Routing DSL in Rails 3, by "Rizwan Reza":http://www.rizwanreza.com/
* Febuary 1, 2010: Modifies the routing documentation to match new routing DSL in Rails 3, by Prem Sichanugrist
Expand Down
2 changes: 0 additions & 2 deletions railties/guides/source/security.textile
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,4 @@ The security landscape shifts and it is important to keep up to date, because mi

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/7

* November 1, 2008: First approved version by Heiko Webers
2 changes: 0 additions & 2 deletions railties/guides/source/testing.textile
Original file line number Diff line number Diff line change
Expand Up @@ -940,8 +940,6 @@ The built-in +test/unit+ based testing is not the only way to test Rails applica

h3. Changelog

"Lighthouse ticket":http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/8

* April 4, 2010: Fixed document to validate XHTML 1.0 Strict. "Jaime Iniesta":http://jaimeiniesta.com
* November 13, 2008: Revised based on feedback from Pratik Naik by "Akshay Surve":credits.html#asurve (not yet approved for publication)
* October 14, 2008: Edit and formatting pass by "Mike Gunderloy":credits.html#mgunderloy (not yet approved for publication)
Expand Down

0 comments on commit 902ae14

Please sign in to comment.