Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CeloTerminal, @celo/sdk & Ledger issues #344

Closed
zviadm opened this issue May 15, 2024 · 3 comments
Closed

[BUG] CeloTerminal, @celo/sdk & Ledger issues #344

zviadm opened this issue May 15, 2024 · 3 comments
Assignees

Comments

@zviadm
Copy link
Owner

zviadm commented May 15, 2024

There is an ongoing issue with @celo/sdk and Ledger Hardware wallets.
This issue provides a brief summary and some potential work arounds.

CeloTerminal currently pins its dependencies on @celo/sdk v4:

  • CeloTerminal and Ledger Nano X with Firmware <=1.2.4-4 should work in all cases.
  • CeloTerminal and Ledger Nano S with Firmware <=1.6.1 should work in all cases.
  • Ledger Nano devices with newer firmware (after support for Ethereum 2.0 was added) will work with CeloTerminal for some simple transactions, but they will start failing with "EthAppPleaseEnableContractData" errors for some more complex transactions.

@celo/sdk v5 (and maybe v8?) no longer work with any version of the Ledger Nano firmware. This is why CeloTerminal is using really old @celo/sdk v4.

Unfortunately there isn't much that can be done in CeloTerminal itself to resolve this issue. We are waiting on @celo/sdk to fix these issues.

@zviadm zviadm self-assigned this May 15, 2024
@zviadm
Copy link
Owner Author

zviadm commented May 15, 2024

Some related open issues in @celo libraries:
celo-org/developer-tooling#221
celo-org/developer-tooling#195

@aaronmgdr
Copy link

Hey sorry its like this. We are working on releasing a new version of the celo ledger app (the one that runs on the device itself) together with upgraded celo sdks that use better tested, more modern dependencies.

@zviadm
Copy link
Owner Author

zviadm commented Sep 29, 2024

These issues should be fixed with #355

@zviadm zviadm closed this as completed Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants