Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable UseShellExecute and bring the window to the front in case Ctrl + Click is used #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable UseShellExecute and bring the window to the front in case Ctrl + Click is used #80

wants to merge 2 commits into from

Conversation

ducmthai
Copy link

@ducmthai ducmthai commented Apr 10, 2021 •
edited
Loading

  • Improvement: Use ProcessStartInfo with UseShellExcute set to false in starting new browser processes. This mechanism bypasses OS shell and starts the browser directly from the executable file.
  • Improvement: If Ctrl + Click is used to follow links and Ctrl is not released, BrowserSelect should be visible. This is an attempt to fix Browser Select window on top #59

@lucasnz
Copy link

lucasnz commented Sep 2, 2021

Thanks. I've cherry picked these commits into my branch. I can't really tell if there's an improvement in speed - but this PR still seems to make sense.

@lucasnz lucasnz mentioned this pull request Feb 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser Select window on top
2 participants
@ducmthai @lucasnz