Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle subscription peer add/remove events #374

Closed
sirpengi opened this issue Nov 10, 2023 · 1 comment
Closed

Handle subscription peer add/remove events #374

sirpengi opened this issue Nov 10, 2023 · 1 comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Milestone

Comments

@sirpengi
Copy link
Contributor

Part of #135

https://zulip.com/api/get-events#subscription-peer_add
https://zulip.com/api/get-events#subscription-peer_remove

This issue is for handling when subscribers on a subscription are being modified. subscription op:add, subscription op:remove and subscription op:update are being handled as part of #187

@gnprice gnprice added this to the Post-launch milestone Nov 13, 2023
@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels Nov 13, 2023
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 14, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 14, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 14, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 15, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 15, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 16, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 17, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 17, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 17, 2023
Add events for subscription with `op` values of `add`,
`remove`, and `update`. `peer_add` and `peer_remove`
left for zulip#374.
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 22, 2024
@gnprice
Copy link
Member

gnprice commented Nov 22, 2024

These events will become relevant only in a future where we start tracking the data that they update, namely the list of other subscribers to each channel.

If we do add such a data structure, we'll naturally go and handle the events that update it; that's the pattern for implementing new pieces of the Zulip data model in general. So I think there isn't an independent task to be tracked here, and isn't a need for this issue to track it.

Instead, if at some point we decide to add a feature that would use that data, we'll file issues as needed to describe what that feature needs.

@gnprice gnprice closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: Done
Development

No branches or pull requests

2 participants