-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msglist: Offer DM-conversation narrows #142
Comments
I think I'll be glad for those cleanups/constructs when it comes to writing DM links for quote-and-reply, #116. 🙂 (Note that our quote-and-reply code in zulip-mobile goes through that |
Probably this should be preceded by: since that will otherwise have to touch a bunch of the code this will add. |
This takes care of the bulk of zulip#142. The only thing missing is a way to navigate to one of these narrows, which we'll add next.
This takes care of the bulk of zulip#142. The only thing missing is a way to navigate to one of these narrows, which we'll add next.
Splitting this out from:
because I have an implementation of the rest of that issue basically ready, but I'm finding that for DM/PM narrows there's a stack of related things I want to build or clean up first, so I'd like to decouple those in order to get the rest of it in.
All of those needed cleanups stem from the fact that a Zulip DM conversation is identified by a list of users, not a single crisp ID — opening up a range of possibilities for the exact format — and that the server API can be a bit chaotic about which format to use. (Compare
src/utils/recipient.js
in zulip-mobile.)The text was updated successfully, but these errors were encountered: