Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Offer DM-conversation narrows #142

Closed
gnprice opened this issue Jun 1, 2023 · 2 comments · Fixed by #160
Closed

msglist: Offer DM-conversation narrows #142

gnprice opened this issue Jun 1, 2023 · 2 comments · Fixed by #160
Assignees
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Jun 1, 2023

Splitting this out from:

because I have an implementation of the rest of that issue basically ready, but I'm finding that for DM/PM narrows there's a stack of related things I want to build or clean up first, so I'd like to decouple those in order to get the rest of it in.

All of those needed cleanups stem from the fact that a Zulip DM conversation is identified by a list of users, not a single crisp ID — opening up a range of possibilities for the exact format — and that the server API can be a bit chaotic about which format to use. (Compare src/utils/recipient.js in zulip-mobile.)

@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jun 1, 2023
@gnprice gnprice added this to the Alpha milestone Jun 1, 2023
@gnprice gnprice self-assigned this Jun 1, 2023
@chrisbobbe
Copy link
Collaborator

All of those needed cleanups stem from the fact that a Zulip DM conversation is identified by a list of users, not a single crisp ID — opening up a range of possibilities for the exact format — and that the server API can be a bit chaotic about which format to use. (Compare src/utils/recipient.js in zulip-mobile.)

I think I'll be glad for those cleanups/constructs when it comes to writing DM links for quote-and-reply, #116. 🙂 (Note that our quote-and-reply code in zulip-mobile goes through that src/utils/recipient.js you mentioned.)

@gnprice
Copy link
Member Author

gnprice commented Jun 1, 2023

Probably this should be preceded by:

since that will otherwise have to touch a bunch of the code this will add.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 8, 2023
This takes care of the bulk of zulip#142.  The only thing missing is
a way to navigate to one of these narrows, which we'll add next.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 8, 2023
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 8, 2023
This takes care of the bulk of zulip#142.  The only thing missing is
a way to navigate to one of these narrows, which we'll add next.
@gnprice gnprice closed this as completed in f7feabf Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants