Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank emoji autocomplete results #1068

Closed
gnprice opened this issue Nov 21, 2024 · 1 comment · Fixed by #1112
Closed

Rank emoji autocomplete results #1068

gnprice opened this issue Nov 21, 2024 · 1 comment · Fixed by #1112
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@gnprice
Copy link
Member

gnprice commented Nov 21, 2024

For the initial implementation of #670, there won't be a useful ordering to the results. This means a user might have to type a longer, more specific query to find their desired emoji than they might with good ranking.

This issue is for ranking the results. The ranking should match what the web app does:
https://github.com/zulip/zulip/blob/65f05794e/web/shared/src/typeahead.ts#L322-L382
(We might make exceptions and depart from that ordering if there are areas where we see an alternative that's substantially better in either quality of results or clarity of code, without being particularly worse on the other axis.)

Broadly, that ranking looks like:

  • "Popular emoji", before realm emoji, before (other) Unicode emoji, where "popular emoji" means a hard-coded list of six emoji like 👍.
  • Names that exactly match the query, before names that have it as a prefix, before other matches.

For details, see the web implementation.

Related issues

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Nov 21, 2024
@gnprice gnprice added this to the Post-launch milestone Nov 21, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M5: Launch Dec 7, 2024
@gnprice gnprice self-assigned this Dec 8, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 8, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji
from other Unicode emoji.  That would break some test cases which
refer to an emoji that happens to be "popular", like 😄, when
they really just intend the generic behavior that happens to any
Unicode emoji.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 8, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 8, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 8, 2024
@gnprice
Copy link
Member Author

gnprice commented Dec 8, 2024

I decided this is a nearer-term priority after trying out the emoji picker from #1103 — the lack of ranking was bugging me basically every time I used the emoji picker. So I've now sent #1112 to implement it.

@gnprice gnprice modified the milestones: M5: Launch, M4: Wider beta Dec 9, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 9, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji
from other Unicode emoji.  That would break some test cases which
refer to an emoji that happens to be "popular", like 😄, when
they really just intend the generic behavior that happens to any
Unicode emoji.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 9, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 9, 2024
@gnprice gnprice closed this as completed in a885520 Dec 9, 2024
shivanshsharma13 pushed a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji
from other Unicode emoji.  That would break some test cases which
refer to an emoji that happens to be "popular", like 😄, when
they really just intend the generic behavior that happens to any
Unicode emoji.
shivanshsharma13 pushed a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
shivanshsharma13 pushed a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
shivanshsharma13 pushed a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant