-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rank emoji autocomplete results #1068
Labels
a-compose
Compose box, autocomplete, attaching files/images
Milestone
Comments
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 8, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji from other Unicode emoji. That would break some test cases which refer to an emoji that happens to be "popular", like 😄, when they really just intend the generic behavior that happens to any Unicode emoji.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 8, 2024
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 8, 2024
Fixes part of zulip#1068.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 8, 2024
This was referenced Dec 8, 2024
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 9, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji from other Unicode emoji. That would break some test cases which refer to an emoji that happens to be "popular", like 😄, when they really just intend the generic behavior that happens to any Unicode emoji.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 9, 2024
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 9, 2024
Fixes part of zulip#1068.
shivanshsharma13
pushed a commit
to shivanshsharma13/zulip-flutter
that referenced
this issue
Dec 13, 2024
We'll soon (for zulip#1068) be adding logic that distinguishes these emoji from other Unicode emoji. That would break some test cases which refer to an emoji that happens to be "popular", like 😄, when they really just intend the generic behavior that happens to any Unicode emoji.
shivanshsharma13
pushed a commit
to shivanshsharma13/zulip-flutter
that referenced
this issue
Dec 13, 2024
shivanshsharma13
pushed a commit
to shivanshsharma13/zulip-flutter
that referenced
this issue
Dec 13, 2024
Fixes part of zulip#1068.
shivanshsharma13
pushed a commit
to shivanshsharma13/zulip-flutter
that referenced
this issue
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the initial implementation of #670, there won't be a useful ordering to the results. This means a user might have to type a longer, more specific query to find their desired emoji than they might with good ranking.
This issue is for ranking the results. The ranking should match what the web app does:
https://github.com/zulip/zulip/blob/65f05794e/web/shared/src/typeahead.ts#L322-L382
(We might make exceptions and depart from that ordering if there are areas where we see an alternative that's substantially better in either quality of results or clarity of code, without being particularly worse on the other axis.)
Broadly, that ranking looks like:
For details, see the web implementation.
Related issues
Autocomplete for emoji in message compose #670
autocomplete: Sort user-mention autocomplete results #228
autocomplete: Give preference to subscribed users first in @-mention autocomplete #618
In topic autocomplete, rank results by match relevance #881
The text was updated successfully, but these errors were encountered: