Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mio 0.4.x #94

Open
zslayton opened this issue Aug 24, 2015 · 8 comments
Open

Upgrade to mio 0.4.x #94

zslayton opened this issue Aug 24, 2015 · 8 comments
Assignees

Comments

@zslayton
Copy link
Owner

Currently running 0.3.x, which generates warnings when building. It will cease to work with rustc 1.3.

@frederikbosch
Copy link
Contributor

We could even upgrade to mio 0.5.0 by now. This might also give this library support for windows. Nonetheless, I would love to see the upgrade. Do you see this happening any time soon? I will have look too!

@zslayton
Copy link
Owner Author

Agreed, targeting 0.5.x would be ideal; I'd love to be able to claim Windows support. I fully intend to do this but recently moved and started a new job, so I haven't had much time to work on my Github projects.

I had hoped to migrate to the latest version of mio by adapting stomp-rs to use mai under the covers. mai is another library I'm working on that exposes a high-level interface to mio's functionality with the goal of making it easier to implement protocols asynchronously. When I last left off, mai had gotten to a point where I could start to modify stomp-rs but I never found the time. Hopefully I can pick this up again in the next couple of weeks!

@frederikbosch
Copy link
Contributor

@zslayton That would be really awesome. I think it would be beneficial for both libraries - mai and stomp-rs - to find developers that can help us.

@zslayton zslayton self-assigned this Feb 24, 2016
@zslayton
Copy link
Owner Author

I haven't forgotten about this. I'm going to work on it this week.

@zslayton
Copy link
Owner Author

zslayton commented Mar 6, 2016

This is proving to be quite the overhaul; the user-facing API is going to end up needing to change a fair amount. I should have an initial version by next weekend.

@frederikbosch
Copy link
Contributor

@zslayton I can imagine. BC breaks for sure. But since we are below 1.0.0 this should be no problem.

@zslayton
Copy link
Owner Author

zslayton commented May 30, 2016

My work on this is now available in this branch. It's working fine but there's a lot of cleanup to be done before I can promote it to master. The documentation in the README hasn't been updated yet. You can look at the send_and_subscribe example for a sense of what it'll look like when it's done.

@frederikbosch
Copy link
Contributor

@zslayton Wonderful! I am going to test soon. You might want to create a PR at the mio package README and put mia in the list of libraries that use mio. Maybe that helps getting people involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants