Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions for fvm are broken as of fvm v3 #1075

Closed
bartekpacia opened this issue Apr 7, 2024 · 7 comments
Closed

Completions for fvm are broken as of fvm v3 #1075

bartekpacia opened this issue Apr 7, 2024 · 7 comments

Comments

@bartekpacia
Copy link

Completion script in question: https://github.com/zsh-users/zsh-completions/blob/master/src/_fvm

As of latest fvm v3.0.0, the above completion script doesn't work. Learn more in leoafarias/fvm#689

ping @syohex who created it (huge thank you and kudos!)

@syohex
Copy link
Contributor

syohex commented Apr 8, 2024

Thanks for reporting issue. It seems fvm supports zsh completion itself now. I'll remove fvm completion from this repository according to our policy.

@bartekpacia
Copy link
Author

It seems fvm supports zsh completion itself now.

Hmm, does it? What do you mean?

@syohex
Copy link
Contributor

syohex commented Apr 8, 2024

I tried new fvm. It generates completion files(e.g. ~/.dart-cli-completion/fvm.zsh) under ~/.dart-cli-completion/ and it appends its configuration in the zsh configuration file(.zshrc etc)

@bartekpacia
Copy link
Author

It generates completion files(e.g. ~/.dart-cli-completion/fvm.zsh) under ~/.dart-cli-completion/ and it appends its configuration in the zsh configuration file(.zshrc etc)

Ah right, it uses this package. But it doesn't work on my machine for some reason. Thanks for checking!

it appends its configuration in the zsh configuration file(.zshrc etc)

I really don't like this behavior. I want my completion scripts to live in e.g. /opt/homebrew/share/zsh/site-functions/, and not modify (!) my dotfiles and ~/.config.

@bartekpacia
Copy link
Author

So yeah, let's remove _fvm from this repo.

Did you write that completion script manually?

@syohex
Copy link
Contributor

syohex commented Apr 8, 2024

Did you write that completion script manually?

Yes

@syohex syohex mentioned this issue Apr 10, 2024
6 tasks
@syohex
Copy link
Contributor

syohex commented Apr 11, 2024

I've removed it at #1076

@syohex syohex closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants