Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from storing wrong credential type for session #2263

Closed
Tracked by #2252
t1m0thyj opened this issue Apr 28, 2023 · 2 comments
Closed
Tracked by #2252

Prevent users from storing wrong credential type for session #2263

t1m0thyj opened this issue Apr 28, 2023 · 2 comments
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have

Comments

@t1m0thyj
Copy link
Member

Steps to Reproduce

  1. Add a profile to Zowe Explorer and store credentials for it.
  2. If stored credentials are username/password, right click on the profile in a tree view and select "Log in to Authentication Service".
  3. If stored credentials are token, right click on the profile and select "Update Credentials".

image

Actual Behavior
The action proceeds without warning, so I can easily misclick and accidentally change the credential type stored for the profile.

Expected Behavior
If username and password are stored for a profile and "Log in to Authentication Service" is selected,
Or token is stored for a profile and "Update Credentials" is selected,
Then a warning message should be shown, prompting the user to confirm they want to change their credential type.

@t1m0thyj t1m0thyj added the enhancement New feature or request label Apr 28, 2023
@github-actions
Copy link

Thank you for raising this issue.
The community has 90 days to upvote 👍 the issue.
If it receives 10 upvotes, we will move it to our backlog. If not, we will close it.

@t1m0thyj t1m0thyj added the priority-low Legit issue but cosmetic or nice-to-have label Apr 28, 2023
@t1m0thyj t1m0thyj linked a pull request Sep 11, 2023 that will close this issue
16 tasks
@JillieBeanSim JillieBeanSim mentioned this issue Sep 25, 2023
31 tasks
@t1m0thyj t1m0thyj moved this from New Issues to Low Priority in Zowe Explorer for VS Code Dec 26, 2023
@t1m0thyj
Copy link
Member Author

This has been resolved now that options for updating credentials have been moved into the "Manage Profile" quickpick, which has a dynamically built list of options that includes only actions that are applicable to the active profile.

@github-project-automation github-project-automation bot moved this from Low Priority to Closed in Zowe Explorer for VS Code Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

1 participant