Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide bos extend currSiz debug message #491

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Hide bos extend currSiz debug message #491

merged 2 commits into from
Sep 25, 2024

Conversation

Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml commented Sep 25, 2024

Proposed changes

This PR addresses Issue:

When the config file is above 4KB, it is processed by chunks. There is a debug message showing this information and is routed to stdout, which makes scripting challenging. See testing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • My code follows the style guidelines of this project (see: [Contributing guideline]
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Run the command with old and new configmgr.

Script

#!/bin/sh

echo "Without fix"
ls -al ./utils/configmgr
result=$(./zwe internal config get -p "zowe.setup.vsam.storageClass" -c ./zowe.yaml)
echo "result=$result"

mv ./utils/configmgr ./utils/configmgr.backup
cp /martin/git/repos/commonC.bos/bin/configmgr  ./utils/configmgr

echo ""

echo "With fix"
ls -al ./utils/configmgr

result=$(./zwe internal config get -p "zowe.setup.vsam.storageClass" -c ./zowe.yaml)
echo "result=$result"

rm ./utils/configmgr
mv ./utils/configmgr.backup ./utils/configmgr

Result

Note: The expected output is empty string.

Without fix
-rwxr-xr-x   1 MARTIN  DEFAULT  4493312 Sep 25 03:43 ./utils/configmgr
result=bos extend currSize=0x0 dataSize=0x1531 chunk=0x1000 extend=0x1531

With fix
-rwxr-xr-x   1 MARTIN  DEFAULT  4489216 Sep 25 04:49 ./utils/configmgr
result=

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JoeNemo JoeNemo merged commit 954377e into v3.x/staging Sep 25, 2024
9 checks passed
@Martin-Zeithaml Martin-Zeithaml deleted the v3.x/bosWrite branch October 1, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants