From e42d6b0ff28e44907eb1986f3a0f8d0ff5439e26 Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Tue, 17 Oct 2023 18:01:37 +0000 Subject: [PATCH 1/3] Use Node 18 and 20 Signed-off-by: Andrew W. Harn --- .github/workflows/zowe-cli-plugin.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zowe-cli-plugin.yml b/.github/workflows/zowe-cli-plugin.yml index 79ac8197..b1a0917a 100644 --- a/.github/workflows/zowe-cli-plugin.yml +++ b/.github/workflows/zowe-cli-plugin.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [16.x, 18.x] + node-version: [18.x, 20.x] os: [windows-latest, ubuntu-latest, macos-latest] env: OS: ${{ matrix.os }} From 75350f9e94ac79815aa886c77d34ad82563948a8 Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Wed, 18 Oct 2023 19:11:07 +0000 Subject: [PATCH 2/3] Check something Signed-off-by: Andrew W. Harn --- .../__unit__/cli/download/data-set/DataSet.Handler.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts b/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts index aeb97e3a..ef5122d9 100644 --- a/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts +++ b/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts @@ -55,6 +55,8 @@ describe("Download data set handler", () => { response: mockResponse }; await handler.processFTP(mockParams); + // eslint-disable-next-line no-console + console.dir(mockResponse.console.log.mock.calls); expect(mockResponse.console.log.mock.calls[0][0]).toBe("Data set downloaded successfully.\nDestination: %s"); expect(mockResponse.console.log.mock.calls[0][1]).toBe("ds1"); expect(mockParams.connection.getDataset.mock.calls[0][1]).toBe("binary_rdw"); From 62bc8766ab0423584ef0c450bbf7cc5327fcd28d Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Wed, 18 Oct 2023 19:25:18 +0000 Subject: [PATCH 3/3] Fix unit test to expect correct message Signed-off-by: Andrew W. Harn --- .../__unit__/cli/download/data-set/DataSet.Handler.test.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts b/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts index ef5122d9..6539efec 100644 --- a/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts +++ b/__tests__/__unit__/cli/download/data-set/DataSet.Handler.test.ts @@ -55,9 +55,7 @@ describe("Download data set handler", () => { response: mockResponse }; await handler.processFTP(mockParams); - // eslint-disable-next-line no-console - console.dir(mockResponse.console.log.mock.calls); - expect(mockResponse.console.log.mock.calls[0][0]).toBe("Data set downloaded successfully.\nDestination: %s"); + expect(mockResponse.console.log.mock.calls[0][0]).toBe("Data set downloaded successfully."); expect(mockResponse.console.log.mock.calls[0][1]).toBe("ds1"); expect(mockParams.connection.getDataset.mock.calls[0][1]).toBe("binary_rdw"); });