Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated key "asnroots" in profile #1052

Closed
matsduf opened this issue Apr 22, 2022 · 1 comment · Fixed by #1257
Closed

Remove deprecated key "asnroots" in profile #1052

matsduf opened this issue Apr 22, 2022 · 1 comment · Fixed by #1257
Assignees
@tgreenx
Labels
P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Apr 22, 2022

Key asnroots was marked as depracated in Zonemaster-Engine version v4.4.0 (Zonemaster release v2020.1). It is time to remove it from code and documentation, or set a release when it will be removed.

=head2 asnroots (DEPRECATED)
An arrayref of domain names. Default C<["asnlookup.zonemaster.net",
"asnlookup.iis.se", "asn.cymru.com"]>.
@matsduf matsduf added the P-High Priority: Issue to be solved before other label Apr 22, 2022
@matsduf matsduf added this to the v2022.1 milestone Apr 22, 2022
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@tgreenx tgreenx self-assigned this Jul 19, 2023
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jul 19, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
62e2dbb 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
@tgreenx tgreenx mentioned this issue Jul 19, 2023
Merged
@tgreenx tgreenx linked a pull request Jul 19, 2023 that will close this issue
Refactor ASNLookup code and documentation #1257
Merged
@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Jul 19, 2023
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Sep 7, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
b74eb77 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Nov 7, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
cddeddc 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Nov 7, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
0c01f94 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Nov 7, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
ba76a5b 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Nov 28, 2023
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
ffaaac0 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue May 16, 2024
@tgreenx
Removes "asnroots" profile parameter - zonemaster#1052
233b757 
This profile parameter was deprecated in 2020.1.

- Remove code
- Remove documentation
- Replace unitary tests from "asnroots" to "asn_db.style" and "asn_db.sources"
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Solved in upcoming release v2024.2 by #1257.

@tgreenx tgreenx closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Milestone
v2024.2
Development

Successfully merging a pull request may close this issue.

Refactor ASNLookup code and documentation tgreenx/zonemaster-engine
2 participants
@matsduf @tgreenx