Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: TransferCallMsg and WithdrawalCallMsg in clients package #65

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

danijelTxFusion
Copy link
Contributor

What 💻

  • Extend TransferCallMsg and WithdrawalCallMsg with GasPerPubdata and CustomSignature fields which can we used in estimation for transfer and withdrawal transactions.
  • Rename the methods to be more convenient.

BREAKING CHANGE: Rename `TransferCallMsg.ToCallMsg` to
`TransferCallMsg.ToL1CallMsg` and `TransferCallMsg.ToZkCallMsg` to
`TransferCallMsg.ToCallMsg`.
BREAKING CHANGE: Rename `WithdrawalCallMsg.ToCallMsg` to
`WithdrawalCallMsg.ToL1CallMsg` and `WithdrawalCallMsg.ToZkCallMsg`
to `WithdrawalCallMsg.ToCallMsg`.
@danijelTxFusion danijelTxFusion requested a review from a team as a code owner November 4, 2024 23:20
@danijelTxFusion danijelTxFusion merged commit bd63b3d into main Nov 4, 2024
5 checks passed
@danijelTxFusion danijelTxFusion deleted the refactor/client-call-msg branch November 4, 2024 23:41
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant