Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign Signer and replace BaseSigner with ECDSASigner #58

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

danijelTxFusion
Copy link
Contributor

@danijelTxFusion danijelTxFusion commented Sep 29, 2024

What 💻

  • Improve the design of Signer interface.
  • Replace the BaseSigner with ECDSASigner, and use ECDSASigner in constructors for Wallet, WalletL1, WalletL2.

BREAKING CHANGE: The `Signer` interface has been redesigned to be minimal and more
extensible. The `BaseSigner` has been replaced by `ECDSASigner`. Additionally,
`Wallet`, `WalletL1`, and `WalletL2` now use `ECDSASigner` in their constructors.
@danijelTxFusion danijelTxFusion requested a review from a team as a code owner September 29, 2024 15:01
@danijelTxFusion danijelTxFusion merged commit a38b8bc into main Sep 29, 2024
5 checks passed
@danijelTxFusion danijelTxFusion deleted the feat/redesign-signer branch September 29, 2024 15:16
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant