Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question regarding decimal_str_amount changes #23

Open
hukkin opened this issue Jul 1, 2021 · 0 comments
Open

Question regarding decimal_str_amount changes #23

hukkin opened this issue Jul 1, 2021 · 0 comments

Comments

@hukkin
Copy link
Contributor

hukkin commented Jul 1, 2021

Some time ago I fixed a few issues with decimal_str_amount. It was an important function because the output of it was used as input when signing, so any error would result in an invalid signature.

A recent commit (c2820a5) changes formatting of zero from 0 to 0.0. I remember that this special casing was important for signing to be in sync with https://github.com/matter-labs/zksync

Was there a change in spec, or should this change be reverted?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hukkin