Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v6 types page has v5 links #85

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat: v6 types page has v5 links #85

merged 3 commits into from
Aug 20, 2024

Conversation

Ngozi-Txfusion
Copy link
Collaborator

What

  • Updated the V6 types page to remove or replace V5 links incorrectly referenced.

Why

  • The V6 types page had outdated links pointing to V5, which could cause confusion or incorrect navigation for users. This update ensures all references are correctly aligned with V6.

@Ngozi-Txfusion Ngozi-Txfusion requested review from a team as code owners August 19, 2024 18:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1435a30):

https://zksync-sdk-docs-staging--pr85-v6-types-page-has-v5-tmtzs68b.web.app

(expires Tue, 27 Aug 2024 09:04:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6539d831ccfa61081c09db66b409eadb94db989

jennyg0
jennyg0 reviewed Aug 19, 2024
View reviewed changes
Copy link

@jennyg0 jennyg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! the updated links are not working for me, all 404

@petarTxFusion petarTxFusion merged commit 832e4af into main Aug 20, 2024
15 checks passed
@petarTxFusion petarTxFusion deleted the v6-types-page-has-v5-links branch August 20, 2024 10:47
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyg0 jennyg0 jennyg0 left review comments

@petarTxFusion petarTxFusion petarTxFusion approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ngozi-Txfusion @jennyg0 @petarTxFusion