-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added some missing pages and update errors in zksync ethers v5 and v6 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 9e35ada): https://zksync-sdk-docs-staging--pr64-resolve-errors-in-et-a7z9dp0x.web.app (expires Wed, 10 Jul 2024 12:02:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f6539d831ccfa61081c09db66b409eadb94db989 |
Ngozi-Txfusion
requested review from
danijelTxFusion,
petarTxFusion and
itsacoyote
July 2, 2024 15:32
content/sdk/10.js/00.ethers/05.api/10.v5/00.providers/02.web3provider.md
Outdated
Show resolved
Hide resolved
content/sdk/10.js/00.ethers/05.api/10.v5/00.providers/02.web3provider.md
Outdated
Show resolved
Hide resolved
content/sdk/10.js/00.ethers/05.api/10.v5/01.accounts/01.wallet.md
Outdated
Show resolved
Hide resolved
danijelTxFusion
approved these changes
Jul 3, 2024
🎉 This issue has been resolved in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
petarTxFusion
pushed a commit
that referenced
this pull request
Jul 8, 2024
…and v6 (#64) * feat: added some missing pages and update errors in zksync ethers * chore: move eip712signer to a dedicated page * chore: structure pages * chore: update links * chore: update intro * chore: minor errors * chore: minor update * chore: minor changes * chore: update description * chore: fix error * chore: fix error * chore: fix error * chore: fix errors * chore: fix errors --------- Co-authored-by: Danijel Radakovic <[email protected]> Co-authored-by: danijelTxFusion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ContractFactory
deployment methods, andProvider
integration.Provider
andAccount
classes to provide better clarity and examples.Why