Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to collect outgoing grpc metrics #349

Open
sashayakovtseva opened this issue Jun 28, 2024 · 3 comments
Open

Add ability to collect outgoing grpc metrics #349

sashayakovtseva opened this issue Jun 28, 2024 · 3 comments

Comments

@sashayakovtseva
Copy link
Contributor

Hello!

I am using github.com/zitadel/zitadel-go/v3/pkg/client to manage Zitadel from my application and I'd like to monitor my outgoing requests.

While there is one way of doing so by writing a custom Zitadel client wrapper that collects metrics, I think it would be better and easier for end users to pass prometheus interceptor (https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/providers/prometheus) directly to grpc connection.

Would you consider adding new client.Option for this purpose?

@fforootd
Copy link
Member

I think this could be a great addition 👍

WDYT @zitadel/engineers

@hifabienne hifabienne moved this to 🧐 Investigating in Product Management Jul 3, 2024
@adlerhurst adlerhurst changed the title Add ability to collect outgoing grpc metrcs Add ability to collect outgoing grpc metrics Jul 15, 2024
@adlerhurst
Copy link
Member

I think this is a great idea. I would prefer to use otel instead of a proprietary product.

Copy link
Contributor

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📨 Product Backlog
Development

No branches or pull requests

4 participants