-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jsonSerialize
return
#1575
Conversation
Looks like you might have to put all changes into a single PR. Also, tool did you use to get this warning? I was under the impression that the attribute would take care of this issue. |
jsonSerialize
return (AbstractAnnotation
)jsonSerialize
return
I use :
In my |
So is the warning from PHP itself or from a static analyser or similar? |
It happens when I run my tests with |
What about bumping the php version to 8.1 in my commit to make all tests pass (or in another one) ? Because 7.x versions are not maintained anymore (and everything will be green for this PR) : see #1577 |
It would be good to get more details as I cannot see those warnings running the swagger-php tests itself. |
I started to see the same warning messages with PHP 8.3 (using symfony 7 and NelmioApiDoc bundle) |
Error triggered from It can be fixed with added phpdoc tag |
Added phpdoc in the |
Sorry, got kind of confused about which PR does what. As you can see from my PR there is also a change in the cs-fixer config required. Happy for you to update your PR or use mine. |
Thanks @AurelienPillevesse |
@DerManoMann do you think it's possible to release a new tag to fix this issue ? |
When I execute my test with the last version of packages + PHP 8.3, I have warnings like this one :