Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for visibilityTimeout in SqsStreamSettings should be set to None #587

Open
GuillaumeSaintRaymondSonos opened this issue Oct 1, 2021 · 0 comments

Comments

@GuillaumeSaintRaymondSonos

It's misleading because if visibilityTimeout is not overriden to None we can't use the value configured globally on the queue. And since it has a default value, it's easy to forget that this field has been set.

I think it will avoid some future suprises if visibilityTimeout is set to Nonehttps://github.com/zio/zio-sqs/blob/master/src/main/scala/zio/sqs/SqsStreamSettings.scala#L9

Especially visibilityTimeout has a value of 30 which is the AWS default value so it doesn't provides much value.

The other default values are fine to me because they affect only the consumer behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant