Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migration to WebdriverIO 5 #93

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

mjdch
Copy link

@mjdch mjdch commented Mar 26, 2019

Working properly migration to WebdriverIO version 5.

@mjdch mjdch changed the title Migration to WebdriverIO 5 WIP: Migration to WebdriverIO 5 Mar 26, 2019
@emilyrohrbough
Copy link

This will be a MVB. Has any of the issues logged been considered for other breaking changes in this tool?

@mjdch
Copy link
Author

mjdch commented Mar 26, 2019

I am refactoring test now, but there is major issue with that:
In old webdriverIO 4 we had browser.setViewportSize() function which setup viewport size of browser so all reference screenshots was valid for tests, now we have browser.setWindowSize() which setups i belive windo size and viewport is different for each browser i.e data from comparison in tests:

[0-0] { isSameDimensions: false, dimensionDifference: { width: 0, height: 19 }, misMatchPercentage: '0.00', analysisTime: 33, getDiffImage: [Function] } [1-0] { isSameDimensions: false, dimensionDifference: { width: 0, height: 14 }, misMatchPercentage: '0.00', analysisTime: 33, getDiffImage: [Function] } [0-0] { isSameDimensions: false, dimensionDifference: { width: 0, height: -1 }, misMatchPercentage: '0.00', analysisTime: 111, getDiffImage: [Function] } 2019-03-26T15:22:31.674Z DEBUG @wdio/local-runner: Runner 0-0 finished with exit code 1 [1-0] { isSameDimensions: false, dimensionDifference: { width: 0, height: -6 }, misMatchPercentage: '0.00', analysisTime: 144, getDiffImage: [Function] }

Check dimension difference, two different browsers for runs for two different viewport dimensions, every time we had different output.

@mjdch
Copy link
Author

mjdch commented Mar 26, 2019

Update:
All unit tests passing on CI tools as well on local, integration test are failing. The only problem now is different implementation/logic in method browser.setVieport (WDIO4) vs browser.setWindowSize() (WDIO5). Will prepare workaround for that, it will extend integration test time a little bit.

The only option is changing windowsize untill we achieve proper viewport.

@dpoetzsch
Copy link

I created a port of the old wdio4 browser.setViewport functionality: https://github.com/mondata-dev/wdio-viewport-size, maybe this helps in driving this forward?

What is the state of this PR, do you have a working version for wdio 5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants