Update for block cache trait #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcash_primitives: Implement `Clone` on bundle marker types
Test with bundled prover instead of local prover.
Prior to this change, it's necessary to implement the entirety of the `WalletRead` trait in order to be able to use the input selection functionality provided by `zcash_client_backend::data_api::input_selection`. This change factors out the minimal operations required for transaction proposal construction to better reflect the principle of least authority and make the input selection code reusable in more contexts. In order to minimize the operations of the newly-created `InputSource` and `ShieldingSource` traits, this change also removes the `min_confirmations` field from transaction proposals, in favor of storing explicit target and anchor heights. This has the effect of limiting the lifetime of transaction proposals to `PRUNING_DEPTH - min_confirmations` blocks.
…ection zcash_client_backend: Factor out `InputSource` from `WalletRead`
Introduce newtypes for Sapling circuit parameters
Co-authored-by: Daira Emma Hopwood <[email protected]>
Update `Cargo.lock` file with upgraded dependency versions.
zcash_client_sqlite: Fix broken intra-doc link on `unstable` feature.
Co-authored-by: Daira Emma Hopwood <[email protected]>
…heck. Co-authored-by: str4d <[email protected]>
…data zcash_client_backend: Add Orchard note commitment tree size to block metadata.
Once `zcash_primitives::sapling` is extracted to `sapling-crypto`, these would have become orphan impls.
…cashd These can be removed after future zcashd refactors.
Refactor Sapling components and builder into `zcash_primitives::sapling`
Co-authored-by: Kris Nuttycombe <[email protected]>
…al representation.
…ng::bundle`. Signed-off-by: Daira Emma Hopwood <[email protected]>
…action::components::sapling`. Signed-off-by: Daira Emma Hopwood <[email protected]>
zcash_client_backend: Fix missing `test-dependencies` feature dependency.
It needn't return the account id that was given as an input, and it shouldn't return an 11-byte diversifier index when a 31-bit child index is more appropriate.
Declare and use NonHardenedChildIndex for transparent
…WalletRead methods. This also moves the `TransparentAddressMetadata` type behind the `transparent-inputs` feature flag and performs associated cleanup.
… secret key derivation.
This separation is in preparation for modifying the `Proposal` type to wrap a vector of proposal steps.
…ns representable.
…ct `data_api::wallet` documentation.
Co-authored-by: str4d <[email protected]>
`zcash_client_backend`: Updates to the `Proposal` data structure
… range when interrupted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.